After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721123 - Fix the back-forward buttons in RTL
Fix the back-forward buttons in RTL
Status: RESOLVED FIXED
Product: gnome-weather
Classification: Applications
Component: general
3.11.x
Other Mac OS
: Normal normal
: ---
Assigned To: GNOME Weather Maintainer(s)
GNOME Weather Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-27 12:57 UTC by Yosef Or Boczko
Modified: 2013-12-27 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: Set the back button arrow icon according to locale's text direction (1.52 KB, patch)
2013-12-27 12:59 UTC, Yosef Or Boczko
committed Details | Review
city: Set the back and forward buttons icon according to locale's text direction (2.53 KB, patch)
2013-12-27 12:59 UTC, Yosef Or Boczko
committed Details | Review

Description Yosef Or Boczko 2013-12-27 12:57:08 UTC
See the patches.
Comment 1 Yosef Or Boczko 2013-12-27 12:59:13 UTC
Created attachment 264927 [details] [review]
window: Set the back button arrow icon according to locale's text direction
Comment 2 Yosef Or Boczko 2013-12-27 12:59:27 UTC
Created attachment 264928 [details] [review]
city: Set the back and forward buttons icon according to locale's text direction
Comment 3 Giovanni Campagna 2013-12-27 13:01:47 UTC
Review of attachment 264927 [details] [review]:

I wish gtk would do this automatically...
Comment 4 Giovanni Campagna 2013-12-27 13:02:36 UTC
Review of attachment 264928 [details] [review]:

Ok
Comment 5 Yosef Or Boczko 2013-12-27 13:08:20 UTC
Review of attachment 264927 [details] [review]:

pushed as 8cc3e2b274257b081f5d2e246ad4fea87606565e - window: Set the back button arrow icon according to locale's text direction
Comment 6 Yosef Or Boczko 2013-12-27 13:08:43 UTC
Review of attachment 264928 [details] [review]:

pushed as a6b1b95c89c774462407c3ecdc3940419c5ccacf - city: Set the back and forward buttons icon according to locale's text direction
Comment 7 Yosef Or Boczko 2013-12-27 13:09:16 UTC
Thanks for the fast review!
Comment 8 Yosef Or Boczko 2013-12-27 13:09:47 UTC
(In reply to comment #3)
> Review of attachment 264927 [details] [review]:
> 
> I wish gtk would do this automatically...

You have idea how to do this automatically?