After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721076 - appsink documentation missing gst_sample_unref
appsink documentation missing gst_sample_unref
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal trivial
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-26 10:06 UTC by erik
Modified: 2013-12-26 11:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (460 bytes, patch)
2013-12-26 10:07 UTC, erik 		reviewed Details | Review
patch (git) (764 bytes, patch)
2013-12-26 10:41 UTC, erik 		committed Details | Review

Description erik 2013-12-26 10:06:33 UTC 
The appsink manual[1] is missing a call of gst_sample_unref() for the sample. The result is a memory leak. Please fix this in docs/manual/advanced-dataaccess.xml.

[1] http://gstreamer.freedesktop.org/data/doc/gstreamer/head/manual/html/section-data-spoof.html
Comment 1 erik 2013-12-26 10:07:31 UTC 
Created attachment 264897 [details] [review]
patch
Comment 2 Sebastian Dröge (slomo) 2013-12-26 10:27:41 UTC 
Can you provide this in "git format-patch" format? For this locally commit the change (make sure to set up git properly to know your name and mail address) and then call "git format-patch -1".
Comment 3 erik 2013-12-26 10:41:55 UTC 
Created attachment 264899 [details] [review]
patch (git)

Sure, here it is
Comment 4 Tim-Philipp Müller 2013-12-26 11:23:47 UTC 
Thanks, pushed:

 commit 2cbab400b2b64481d7ba4d4645d42ec6598850cb
 Author: Erik Andresen <erik@vontaene.de>
 Date:   Thu Dec 26 11:39:27 2013 +0100

    docs: fix memory leak of appsink example in manual
    
    https://bugzilla.gnome.org/show_bug.cgi?id=721076