After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721000 - Conversation view images don't appear when compiled w/ Vala 0.23.1
Conversation view images don't appear when compiled w/ Vala 0.23.1
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: client
master
Other Linux
: Normal normal
: 0.6.0
Assigned To: Jim Nelson
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-24 01:23 UTC by Jim Nelson
Modified: 2014-01-07 02:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jim Nelson 2013-12-24 01:23:06 UTC 
When compiled with Vala 0.23.1, no images appear in the conversation viewer.  This includes icons like the drop-down menu, star, and the attachment icon.

This warning appears at startup:

GLib-CRITICAL **: g_base64_encode_step: assertion 'in != NULL' failed

Relevant part of the backtrace:

+ Trace 232952

  • #2 g_base64_encode_step
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #3 g_base64_encode
    from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  • #4 assemble_data_uri
    at /home/jim/git/geary/src/client/util/util-webkit.vala line 408
  • #5 conversation_web_view_set_icon_src
    at /home/jim/git/geary/src/client/conversation-viewer/conversation-web-view.vala line 219
  • #6 conversation_web_view_on_load_finished
    at /home/jim/git/geary/src/client/conversation-viewer/conversation-web-view.vala line 145
  • #7 _conversation_web_view_on_load_finished_webkit_web_view_load_finished
    at /home/jim/git/geary/src/client/conversation-viewer/conversation-web-view.vala line 39 

The conversation viewer uses Base64 to encode images as data: URIs.  I suspect the bindings changed between Vala 0.22.1 and Vala 0.23.1.
Comment 1 Jim Nelson 2013-12-24 02:07:50 UTC 
It's not a binding problem after all: bug #721001.  Unfortunately, this bug may have other consequences in Geary and Shotwell.  We won't know without a code audit.

Will decide how to proceed after the Vala maintainers respond.
Comment 2 Jim Nelson 2014-01-03 20:07:08 UTC 
The Vala maintainers have called this a non-bug, so it'll need to be fixed in Geary.  Additionally, I'll audit Geary for other places this bug may be lurking.
Comment 3 Jim Nelson 2014-01-07 02:20:19 UTC 
Fixed in master, commit 56d31a38