After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720963 - nm-devices.xml dbus type error
nm-devices.xml dbus type error
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: API
0.9.8
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-23 07:51 UTC by snyh
Modified: 2014-04-25 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
introspection: fix Device.Ip4Address type (882 bytes, patch)
2013-12-23 17:56 UTC, Dan Winship 		accepted-commit_now Details | Review

Description snyh 2013-12-23 07:51:08 UTC 
http://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/introspection/nm-device.xml?id=0.9.8.8#n54

The Ip4Address's type should be "u".


According to the org.freedesktop.DBus.Introspector's result it should be an "u" instead of "i".
Comment 1 Dan Winship 2013-12-23 17:56:52 UTC 
Created attachment 264808 [details] [review]
introspection: fix Device.Ip4Address type
Comment 2 Thomas Haller 2014-01-02 23:59:43 UTC 
(In reply to comment #1)
> Created an attachment (id=264808) [details] [review]
> introspection: fix Device.Ip4Address type

What are the consequences of changing the type? (regarding breaking changes).

Also, if you apply this patch, you might want to do it for master too (although, this property got deprecated in the meantime).
Comment 3 Dan Winship 2014-01-03 20:02:39 UTC 
(In reply to comment #2)
> What are the consequences of changing the type? (regarding breaking changes).

This doesn't change the type of the data (which is unsigned in both src/devices/nm-device.c and libnm-glib/nm-device.c), it merely fixes the introspection data to match reality.

(And dbus-glib doesn't use the type data from the introspection for handling properties, so there won't be any changes in how it gets processed internally within NM either. It is possible that some other non-dbus-glib-based library might have been mishandling the property before, and will now start handling it correctly.)

> Also, if you apply this patch, you might want to do it for master too
> (although, this property got deprecated in the meantime).

Oh, I was only planning to apply it to master.
Comment 4 Dan Williams 2014-04-25 16:35:29 UTC 
Review of attachment 264808 [details] [review]:

Looks good to me.