After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720960 - Startup Applications tab broken if using Global Dark Theme
Startup Applications tab broken if using Global Dark Theme
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-23 03:50 UTC by Salvatore La Bua
Modified: 2014-01-07 11:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
When in foreground (62.76 KB, image/png)
2013-12-23 03:51 UTC, Salvatore La Bua 		  Details
When in background (66.96 KB, image/png)
2013-12-23 03:52 UTC, Salvatore La Bua 		  Details
fix background color of startup applications (2.04 KB, patch)
2014-01-07 04:26 UTC, Alex Muñoz 		accepted-commit_now Details | Review

Description Salvatore La Bua 2013-12-23 03:50:14 UTC 
The background colour of the applications list shown in the Startup Applications tab is still white with white text when the Global Dark Theme is used, and the gnome-tweak-tool window is in foreground. The text changes to gray still on white when the window goes in background.
I suppose the solution would be to simply change the background colour of such list according to the theme used. I think the text itself is fine already.
Comment 1 Salvatore La Bua 2013-12-23 03:51:34 UTC 
Created attachment 264788 [details]
When in foreground
Comment 2 Salvatore La Bua 2013-12-23 03:52:12 UTC 
Created attachment 264789 [details]
When in background
Comment 3 John Stowers 2014-01-06 10:11:12 UTC 
Agree - this looks bad. Confirmed in

https://www.youtube.com/watch?v=WMTwVsIWu6Q (1:04:00)

Alex, can you take a look at this?
Comment 4 Alex Muñoz 2014-01-06 17:55:24 UTC 
ok John!, I'm going to fix it!
Comment 5 John Stowers 2014-01-06 18:05:13 UTC 
cool, it should be similar to how we support dark themes in the other views (check the commit history, I remember someone submitted a patch)
Comment 6 Alex Muñoz 2014-01-07 04:26:27 UTC 
Created attachment 265506 [details] [review]
fix background color of startup applications
Comment 7 Salvatore La Bua 2014-01-07 09:50:26 UTC 
Thanks, it looks good now :)
Comment 8 John Stowers 2014-01-07 10:16:12 UTC 
Review of attachment 265506 [details] [review]:

Great!

Please commit to master and cherry pick to gnome-3-10 branch
Comment 9 Alex Muñoz 2014-01-07 11:02:51 UTC 
Done!