After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720958 - Fix transient_for of about dialog
Fix transient_for of about dialog
Status: RESOLVED WONTFIX
Product: gnome-terminal
Classification: Core
Component: general
3.11.x
Other Mac OS
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-23 02:04 UTC by Yosef Or Boczko
Modified: 2014-02-18 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Fix transient_for of about dialog (782 bytes, patch)
2013-12-23 02:05 UTC, Yosef Or Boczko 		none Details | Review
app: Fix transient_for of about dialog - more a way (864 bytes, patch)
2013-12-25 21:35 UTC, Yosef Or Boczko 		none Details | Review

Description Yosef Or Boczko 2013-12-23 02:04:28 UTC 
The about dialog it isn't modal when is launc
from the app-menu.
Comment 1 Yosef Or Boczko 2013-12-23 02:05:18 UTC 
Created attachment 264779 [details] [review]
app: Fix transient_for of about dialog
Comment 2 Christian Persch 2013-12-25 21:23:41 UTC 
Why is not being modal a problem?

The patch is wrong in that get_active_window might return an non-TerminalWindow (ie another dialogue).
Comment 3 Yosef Or Boczko 2013-12-25 21:29:03 UTC 
What you mean this is another problem,.
You can to open the prep dialog, and after this
to open the about dialog from the menubar, and
to get the same problem.

So I think the patch is right for the modal dialog generally.
What you mean is another bug, right to each app.
Comment 4 Yosef Or Boczko 2013-12-25 21:35:38 UTC 
Created attachment 264886 [details] [review]
app: Fix transient_for of about dialog - more a way

I not see any change, but see this idea.
Comment 5 Christian Persch 2014-01-06 15:12:42 UTC 
(In reply to comment #3)
> What you mean this is another problem,.
> You can to open the prep dialog, and after this
> to open the about dialog from the menubar, and
> to get the same problem.

I don't understand what you mean?
Comment 6 Christian Persch 2014-02-18 20:33:57 UTC 
I made it not use transient parent when called from window Help->About either.