Created attachment 264760 [details] [review]
Allow translators to add search engine options

Translators now have three placeholder search engines that they may
choose to add to the search engine combo in the preferences dialog.

A quick, inelegant implementation that's probably sufficient. I figure if translators want more engines (unlikely?), then we can always add another.

Review of attachment 264760 [details] [review]:

I'd like to see a hook added to make sure that translations aren't broken for those items as well. That might require a bit more work...

::: src/prefs-dialog.c
@@ +1027,3 @@
+					     /* Search engine option in the preferences dialog. Can be used
+					      * to add an extra search engine option for your region. This
+					      * engine will be ignored if its name includes Placeholder. */

Mention to leave the comment empty to not be shown instead.

@@ +1040,3 @@
 	for (i = 0; i < G_N_ELEMENTS (default_engines); ++i)
 	{
+		if (strstr (_(default_engines[i][0]), "Placeholder"))

That's not really enough if the name got translated, and not the website URL.

(In reply to comment #2)
> Review of attachment 264760 [details] [review]:
> 
> I'd like to see a hook added to make sure that translations aren't broken for
> those items as well. That might require a bit more work...

Do you mean a test in 'make check', or something else?

Remember this?

Translators can translate the default search engines or add as many as they want now, bug #776738.