After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720916 - When changing software sources, "Another action is in progress" is displayed
When changing software sources, "Another action is in progress" is displayed
Status: RESOLVED FIXED
Product: gnome-packagekit
Classification: Core
Component: general
3.11.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-packagekit-maint
gnome-packagekit-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-22 04:46 UTC by Michael Catanzaro
Modified: 2013-12-28 01:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix progress label in Software Sources (1.41 KB, patch)
2013-12-22 20:08 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2013-12-22 04:46:31 UTC
When adding or removing software sources, "Another action is in progress" is briefly displayed. However, the action currently in progress is the addition or removal of the requested source, so the word "another" is confusing and inaccurate.

Also, sometimes this is displayed very, very briefly. It should only display if the action takes a little while (more than a fraction of a second).
Comment 1 Michael Catanzaro 2013-12-22 20:08:32 UTC
(In reply to comment #0)
> When adding or removing software sources, "Another action is in progress" is
> briefly displayed. However, the action currently in progress is the addition or
> removal of the requested source, so the word "another" is confusing and
> inaccurate.

Caused by the changes to gpk_prefs_status_changed_timeout_cb() in https://git.gnome.org/browse/gnome-packagekit/commit/src/gpk-prefs.c?id=6c0b919b633d77c625a248a72140b524170871fa

> Also, sometimes this is displayed very, very briefly. It should only display if
> the action takes a little while (more than a fraction of a second).

Well this is already the case, I'm just unlucky enough to see my actions take a teensy bit longer than the timeout....
Comment 2 Michael Catanzaro 2013-12-22 20:08:48 UTC
Created attachment 264770 [details] [review]
Fix progress label in Software Sources

Since progress messages were removed, the fallback message "Another
action is currently in progress" is shown instead. Use a more generic
message to be more accurate.
Comment 3 Richard Hughes 2013-12-24 13:58:56 UTC
Review of attachment 264770 [details] [review]:

Looks good, thanks.
Comment 4 Michael Catanzaro 2013-12-28 01:55:58 UTC
Attachment 264770 [details] pushed as 1a55b83 - Fix progress label in Software Sources