After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720913 - update window button settings for csd
update window button settings for csd
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-22 03:08 UTC by Matthias Clasen
Modified: 2014-02-12 17:08 UTC
See Also:
GNOME target: 3.12
GNOME version: ---

Attachments
add support for csd windows with header bars (3.13 KB, patch)
2013-12-24 15:42 UTC, Alex Muñoz 		none Details | Review
add support for csd windows with header bars (3.17 KB, patch)
2014-01-14 06:48 UTC, Alex Muñoz 		committed Details | Review

Description Matthias Clasen 2013-12-22 03:08:59 UTC 
For csd windows with header bars, GTK+ now looks at the Gtk/DecorationLayout xsetting. The format of the string looks like this:

menu:minimize,maximize,close

for a menu button (app menu fallback) on the left, and min/max/close on the right. To set this, you should add a suitable entry to the org.gnome.settings-daemon.plugins.xsettings overrides setting, e.g.:

{'Gtk/DecorationLayout': <':minimize,maximize,close'>}
Comment 1 Alex Muñoz 2013-12-24 15:42:29 UTC 
Created attachment 264844 [details] [review]
add support for csd windows with header bars
Comment 2 Matthias Clasen 2014-01-13 13:10:52 UTC 
Ping, would be great to get this merged
Comment 3 John Stowers 2014-01-13 15:02:13 UTC 
Alex - go ahead and commit this to master. We actually depend on this new layout since bug 722017 was committed.
Comment 4 Alex Muñoz 2014-01-14 06:48:21 UTC 
Created attachment 266231 [details] [review]
add support for csd windows with header bars
Comment 5 Giovanni Campagna 2014-02-05 12:42:10 UTC 
See also bug 723669, which has a different approach on this (and would require no change from gnome-tweak-tool)
Comment 6 John Stowers 2014-02-05 12:56:52 UTC 
Thanks Giovanni - I will keep an eye on that bug.

Alex, what was the problem you mentioned you had with your patch?
Comment 7 Alex Muñoz 2014-02-10 15:40:22 UTC 
Sorry for the delay!
the patch works, the problem is when more than one tweak that depends of the xsettings is changed, only  the last changed tweak is applied.
Comment 8 John Stowers 2014-02-10 16:12:43 UTC 
(In reply to comment #7)
> Sorry for the delay!
> the patch works, the problem is when more than one tweak that depends of the
> xsettings is changed, only  the last changed tweak is applied.

Did you try and fix this? I think the xsettingsmanager should be a singleton, so you are probbably just seeing some async race condition.

It should not be too hard to fix...
Comment 9 Alex Muñoz 2014-02-12 17:06:10 UTC 
Review of attachment 266231 [details] [review]:

Pushed as f79ab44