After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720891 - g_settings_get_child does not inherit the backend
g_settings_get_child does not inherit the backend
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gsettings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-12-21 17:51 UTC by Matthias Clasen
Modified: 2014-01-02 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
g_settings_get_child(): inherit backend (1.01 KB, patch)
2013-12-22 04:17 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Matthias Clasen 2013-12-21 17:51:09 UTC
so, if I call get_child on a delayed settings object, the child object will not be delayed
Comment 1 Allison Karlitskaya (desrt) 2013-12-22 04:17:22 UTC
Created attachment 264747 [details] [review]
g_settings_get_child(): inherit backend

Part of the purpose of g_settings_get_child() was that it could be used
after you delay() a GSettings object, and then apply() all of the
settings together.  In order for that to work, we need to share the
backend.
Comment 2 Matthias Clasen 2014-01-02 04:39:03 UTC
Review of attachment 264747 [details] [review]:

Looks as expected.
I guess you will need to adjust some tests for this now - I pushed a bunch of test coverage work that I've done over the break
Comment 3 Allison Karlitskaya (desrt) 2014-01-02 06:51:01 UTC
Attachment 264747 [details] pushed as c7636ce - g_settings_get_child(): inherit backend

No fixups required.
Comment 4 Allison Karlitskaya (desrt) 2014-01-02 06:56:15 UTC
I accidentally tested the commit against the stable branch.  You were right -- this tripped up one of your new tests.  Pushed a fix.