GNOME Bugzilla – Bug 720876
A few fixes for the location entry
Last modified: 2014-01-07 23:09:43 UTC
Here are a number of small fixes for the location entry, drag icon, and completion list.
Created attachment 264680 [details] [review] Don't show ephy-about: in the UI
Created attachment 264681 [details] [review] Don't show null in page title for about:plugins If for some reason an about: page doesn't load the next startup will show one of the error screens. Those screens assume they can get a hostname for the URL. There is no hostname for about: schemes. So, in that case just display the entire URL.
Created attachment 264682 [details] [review] Always use a favicon in the drag surface
Created attachment 264683 [details] [review] Center the favicon vertically on the drag surface
Created attachment 264684 [details] [review] Add more padding around the drag surface
Created attachment 264685 [details] [review] Increase the row padding in the completion menu
Created attachment 264686 [details] [review] Match spacing in current Adwaita
Created attachment 264687 [details] [review] Use a smaller text size for the url line in the completion menu
*** Bug 720869 has been marked as a duplicate of this bug. ***
Review of attachment 264680 [details] [review]: Marking as reviewed. ::: lib/widgets/ephy-location-entry.c @@ +681,3 @@ + *url = str; + } + /* Do not show internal ephy-about: protocol to users */ Not a big fan of the call by reference and posterior freeing, as it assumes memory is allocated and someone might misuse this.
Review of attachment 264681 [details] [review]: Good!
Review of attachment 264682 [details] [review]: Just a minor comment. ::: lib/widgets/ephy-location-entry.c @@ +814,3 @@ g_free (title); g_string_free (text, TRUE); + g_clear_object (&favicon); I don't think you need g_clear_object() here, as it's a local variable. g_object_unref() should be enough.
Review of attachment 264683 [details] [review]: OK
Review of attachment 264684 [details] [review]: OK
Review of attachment 264685 [details] [review]: OK
Review of attachment 264686 [details] [review]: OK
Review of attachment 264687 [details] [review]: ::: lib/widgets/ephy-location-entry.c @@ +1096,3 @@ &color); + color_text = g_strdup_printf ("#%02X%02X%02X", I'd split this into a rgba_to_hex() function. Also, as pango can quite "large" #ffffffffffff type hex values for colours (see pango_color_parse), I'd multiply by 65535 and drop the rounding.
(In reply to comment #12) > I don't think you need g_clear_object() here, as it's a local variable. > g_object_unref() should be enough. It is a convenient null check.
Created attachment 265607 [details] [review] Use a smaller text size for the url line in the completion menu
Created attachment 265611 [details] [review] Use a smaller text size for the url line in the completion menu
Attachment 264680 [details] pushed as e504fb8 - Don't show ephy-about: in the UI Attachment 264681 [details] pushed as fb0de41 - Don't show null in page title for about:plugins Attachment 264682 [details] pushed as 4f76ca4 - Always use a favicon in the drag surface Attachment 264683 [details] pushed as 0b1e5e0 - Center the favicon vertically on the drag surface Attachment 264684 [details] pushed as 4fc7602 - Add more padding around the drag surface Attachment 264685 [details] pushed as a22a8ae - Increase the row padding in the completion menu Attachment 264686 [details] pushed as a576059 - Match spacing in current Adwaita Attachment 265611 [details] pushed as a61723c - Use a smaller text size for the url line in the completion menu