After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720854 - build: Enable validation of the AppData file
build: Enable validation of the AppData file
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-20 23:37 UTC by Philip Withnall
Modified: 2014-02-06 19:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Enable validation of the AppData file (2.26 KB, patch)
2013-12-20 23:37 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2013-12-20 23:37:37 UTC 
Fairly trivial patch to rejig the build rules for the AppData to use appdata-tools (https://github.com/hughsie/appdata-tools) to enable validation of the file (including its translations) during `make check`. This depends on the latest version of gnome-common to pull in the appdata-xml.m4 macro file.

Totem’s AppData file validates successfully, so needs no changes itself.
Comment 1 Philip Withnall 2013-12-20 23:37:39 UTC 
Created attachment 264654 [details] [review]
build: Enable validation of the AppData file

Add a build-time dependency on appdata-tools to enable validation of the
AppData file during `make check`. See:
https://github.com/hughsie/appdata-tools.

This also requires an up-to-date version of gnome-common to pull in the
appdata-xml.m4 macros.
Comment 2 Bastien Nocera 2014-01-08 13:04:01 UTC 
Review of attachment 264654 [details] [review]:

Looks good.
Comment 3 Philip Withnall 2014-01-10 19:13:03 UTC 
Attachment 264654 [details] pushed as 5c345b9 - build: Enable validation of the AppData file
Comment 4 Adam Williamson 2014-02-06 00:44:56 UTC 
This did not implement --enable/--disable-appdata-validate . I think it was supposed to, or else we can't build it downstream.
Comment 5 Philip Withnall 2014-02-06 10:19:25 UTC 
Should work fine: --[enable|disable]-appdata-validate is defined in APPDATA_XML here: https://github.com/hughsie/appdata-tools/blob/master/data/appdata-xml.m4

Is that macro getting pulled into your build process?
Comment 6 Adam Williamson 2014-02-06 17:06:33 UTC 
that's...odd, then. hughsie added it to the package build, but the build still tries to validate the appdata unless I patch it out.
Comment 7 Bastien Nocera 2014-02-06 18:07:12 UTC 
(In reply to comment #6)
> that's...odd, then. hughsie added it to the package build, but the build still
> tries to validate the appdata unless I patch it out.

You'll need to run autoreconf, the version of appdata-tools on the machine of the maintainer/package maker (probably mine) is too old.
Comment 8 Adam Williamson 2014-02-06 18:12:30 UTC 
Cool, testing that right now, if it works with the autogen.sh but without the appdata check reversion patch I'll just send a -2 through without the patch.
Comment 9 Adam Williamson 2014-02-06 19:29:19 UTC 
confirmed, so the problem was just that the 3.11.5 tarball was built with a too-old local copy. after an autogen.sh it accepts the parameter and correctly skips the validation.