After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720853 - Add AppData file validation
Add AppData file validation
Status: RESOLVED FIXED
Product: almanah
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: diary-maint
diary-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-20 23:22 UTC by Philip Withnall
Modified: 2014-01-26 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Update git.mk from upstream (12.21 KB, patch)
2013-12-20 23:22 UTC, Philip Withnall 		none Details | Review
build: Split EXTRA_DIST and CLEANFILES up in data/Makefile.am (2.53 KB, patch)
2013-12-20 23:22 UTC, Philip Withnall 		none Details | Review
build: Enable validation of the AppData file (1.74 KB, patch)
2013-12-20 23:22 UTC, Philip Withnall 		none Details | Review

Description Philip Withnall 2013-12-20 23:22:15 UTC 
A couple of patches here to rearrange the AppData build system, adding a build-time dependency on appdata-tools, and enabling validation of the AppData file (including its translations) at `make check` time.

This requires appdata-tools (https://github.com/hughsie/appdata-tools) and the latest version of gnome-common (which adds support for the appdata-xml.m4 macros).
Comment 1 Philip Withnall 2013-12-20 23:22:17 UTC 
Created attachment 264651 [details] [review]
build: Update git.mk from upstream
Comment 2 Philip Withnall 2013-12-20 23:22:20 UTC 
Created attachment 264652 [details] [review]
build: Split EXTRA_DIST and CLEANFILES up in data/Makefile.am

Make each section of the Makefile self-contained.
Comment 3 Philip Withnall 2013-12-20 23:22:23 UTC 
Created attachment 264653 [details] [review]
build: Enable validation of the AppData file

Add a build-time dependency on appdata-tools to enable validation of the
AppData file during `make check`. See:
https://github.com/hughsie/appdata-tools.
Comment 4 Álvaro Peña 2014-01-26 17:47:46 UTC 
Just applied the patches to master. Apologies for my delay. Thank you Philip for your patches!