After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720836 - Gstreamer Playbin setting states
Gstreamer Playbin setting states
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: GstPlaybin plugin
git master
Other All
: Normal major
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-20 16:19 UTC by Siva
Modified: 2014-01-14 21:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to disable changing the gst state during BUFFERING and CLOCK_LOST (863 bytes, patch)
2013-12-20 20:39 UTC, Siva
none Details | Review
renderer-gst: Don't handle buffering/clock-lost (5.18 KB, patch)
2013-12-21 11:03 UTC, Jens Georg
committed Details | Review

Description Siva 2013-12-20 16:19:49 UTC
Issue: Video not playing smoothly and if user issue stop command, same video will start playing back again. State transitioning does not work properly. 

When Rygel gets following message.Types from the GST bus, rygel should not be setting the GST states PLAYING or PAUSED.  GST itself capable of handling the BUFFERING and CLOCK_LOST.  It confuses the Gstreamer and as a result video freezing and video stop does not working properly.  Our Gstreamer team have confirmed that rygel should not be handling following message types in GST point of view.

MessageType.BUFFERING:
MessageType.CLOCK_LOST:

by removing following state changing statements in both cases, now stop command works properly and video is playing back lot smoother than before.

//this.playbin.set_state (State.PAUSED);
//this.playbin.set_state (State.PLAYING);

Please let us know any feedback.

Thanks,
Siva
Comment 1 Siva 2013-12-20 20:39:28 UTC
Created attachment 264645 [details] [review]
Patch to disable changing the gst state during BUFFERING and CLOCK_LOST
Comment 2 Jens Georg 2013-12-21 10:48:39 UTC
I'm more than happy to remove this; I was told we should handle it, though. I'll prepare a patch to remove the whole message handling.
Comment 3 Jens Georg 2013-12-21 11:03:01 UTC
Created attachment 264674 [details] [review]
renderer-gst: Don't handle buffering/clock-lost

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 4 Jens Georg 2013-12-21 11:03:25 UTC
Can you check whether this patch works for you as well?
Comment 5 Siva 2013-12-30 18:19:03 UTC
Yes. Verified that renderer-gst:don't handle buffering/clock-lost patch also works fine.
Comment 6 Jens Georg 2014-01-14 21:43:26 UTC
Attachment 264674 [details] pushed as 943a61d - renderer-gst: Don't handle buffering/clock-lost