After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720814 - Sometimes all members join after the user connect to a room
Sometimes all members join after the user connect to a room
Status: RESOLVED DUPLICATE of bug 710006
Product: polari
Classification: Applications
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-20 09:54 UTC by Carlos Soriano
Modified: 2013-12-20 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
chatView: Add timeout for "member joined" messages (2.40 KB, patch)
2013-12-20 11:08 UTC, Carlos Soriano 		rejected Details | Review

Description Carlos Soriano 2013-12-20 09:54:14 UTC 
Sometimes, after the user connect a channel, telephaty trigger member-joined signal for each contact, so you end with a bunch of "X joined" messages at the same time.
That's something that was also happening in empathy.

I guess this is something telepathy should handle better with a timeout or something.
But I wonder if maybe it is easier/quick to add a timeout on our side on room connection to show those messages.
Comment 1 Carlos Soriano 2013-12-20 11:08:19 UTC 
Created attachment 264608 [details] [review]
chatView: Add timeout for "member joined" messages

Sometimes telepathy triggers 'member-joined' signals for each
member inmediately after connecting to a room.
Add a tiemout to prevent this.
Comment 2 Florian Müllner 2013-12-20 11:22:41 UTC 
Review of attachment 264608 [details] [review]:

We already do that (see IGNORE_STATUS_TIME in chatView.js), though apparently 5 seconds is still not enough in some cases ...
Comment 3 Florian Müllner 2013-12-20 11:24:47 UTC 
See bug 710006 for the original report.
Comment 4 Carlos Soriano 2013-12-20 11:32:44 UTC 
Oh true, didn't see that bug report. And also didn't see the code.
How about 10 seconds?
Comment 5 Carlos Soriano 2013-12-20 11:33:39 UTC 

*** This bug has been marked as a duplicate of bug 710006 ***