GNOME Bugzilla – Bug 720813
qtmux: Invalid calculation of descriptor length
Last modified: 2013-12-26 08:01:58 UTC
I just ran the static analyser "cppcheck" over the source code
It said many things, including
[descriptors.c:89]: (style) Expression '(X & 0x80) == 0x1' is always false.
Source code is
next = ((ptr[index] & 0x80) == 1);
Suggest code rework.
Created attachment 264607 [details] [review]
qtdemux: Fix reading of descriptor length
Please try to confirm in the future that such bugs still exist in the latest release, it's quite some time since 0.10.31 :)
This one is still valid though, I think the above patch fixes it if I understand correctly how this is supposed to work.
>Please try to confirm in the future that such bugs still exist in the latest
>release, it's quite some time since 0.10.31 :)
Indeed. I should have said 1.2.1, but as you found, latest
code has the problem also.
The chances of me, and possibly other folks, checking the latest code
are dramatically increased by having that code viewable online.
This might be a good enhancement for the gstreamer.freedesktop.org website.
It's all viewable online here: http://cgit.freedesktop.org/gstreamer/
Author: Sebastian Dröge <email@example.com>
Date: Fri Dec 20 11:45:38 2013 +0100
qtdemux: Fix calcuation of descriptor length