After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720813 - qtmux: Invalid calculation of descriptor length
qtmux: Invalid calculation of descriptor length
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.31
Other Linux
: Normal normal
: 1.2.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-20 09:31 UTC by dcb
Modified: 2013-12-26 08:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Fix reading of descriptor length (794 bytes, patch)
2013-12-20 10:46 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description dcb 2013-12-20 09:31:30 UTC 
I just ran the static analyser "cppcheck" over the source code
of gst-plugins-good-0.10.31.

It said many things, including

[descriptors.c:89]: (style) Expression '(X & 0x80) == 0x1' is always false.

Source code is

    next = ((ptr[index] & 0x80) == 1);

Suggest code rework.
Comment 1 Sebastian Dröge (slomo) 2013-12-20 10:46:15 UTC 
Created attachment 264607 [details] [review]
qtdemux: Fix reading of descriptor length
Comment 2 Sebastian Dröge (slomo) 2013-12-20 10:48:53 UTC 
Please try to confirm in the future that such bugs still exist in the latest release, it's quite some time since 0.10.31 :)

This one is still valid though, I think the above patch fixes it if I understand correctly how this is supposed to work.
Comment 3 dcb 2013-12-20 11:09:34 UTC 
>Please try to confirm in the future that such bugs still exist in the latest
>release, it's quite some time since 0.10.31 :)

Indeed. I should have said 1.2.1, but as you found, latest
code has the problem also.

The chances of me, and possibly other folks, checking the latest code 
are dramatically increased by having that code viewable online. 

This might be a good enhancement for the gstreamer.freedesktop.org website.
Comment 4 Sebastian Dröge (slomo) 2013-12-20 11:17:15 UTC 
It's all viewable online here: http://cgit.freedesktop.org/gstreamer/
Comment 5 Sebastian Dröge (slomo) 2013-12-23 14:48:41 UTC 
commit 371482a90c089f5d302747933cfb6d1fc327a168
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Fri Dec 20 11:45:38 2013 +0100

    qtdemux: Fix calcuation of descriptor length
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720813