After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720808 - Negative old start line number in diff view
Negative old start line number in diff view
Status: RESOLVED FIXED
Product: libgit2-glib
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-20 07:16 UTC by Techlive Zheng
Modified: 2019-02-22 03:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the negative-diff-old-start-line (20.09 KB, image/png)
2013-12-20 07:16 UTC, Techlive Zheng 		  Details
The return value should be an int (1.61 KB, patch)
2013-12-20 07:18 UTC, Techlive Zheng 		accepted-commit_now Details | Review

Description Techlive Zheng 2013-12-20 07:16:26 UTC 
Created attachment 264602 [details]
Screenshot of the negative-diff-old-start-line

'ggit_diff_hunk_get_old_start()' returns a negative start line number.
Comment 1 Techlive Zheng 2013-12-20 07:18:23 UTC 
Created attachment 264603 [details] [review]
The return value should be an int

Fix
Comment 2 Techlive Zheng 2013-12-21 17:26:44 UTC 
See branch wip/techlivezh/fix-72808
Comment 3 jessevdk@gmail.com 2013-12-23 09:19:28 UTC 
Review of attachment 264603 [details] [review]:

Nice catch!
Comment 4 Techlive Zheng 2013-12-23 09:22:16 UTC 
(In reply to comment #3)
> Review of attachment 264603 [details] [review]:
> 
> Nice catch!

Then, I will push this commit to master.
Comment 5 Techlive Zheng 2013-12-23 09:40:58 UTC 
Fixed in commit b428e86.