After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720758 - blocking sync call at startup
blocking sync call at startup
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-19 17:35 UTC by William Jon McCann
Modified: 2014-01-07 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revert "ephy-embed-single: also initialize nspluginwrapper plugins in WebKit2" (1.52 KB, patch)
2013-12-19 17:38 UTC, Bastien Nocera 		committed Details | Review

Description William Jon McCann 2013-12-19 17:35:04 UTC 
In ancient history we added:

commit bd03e748e07dd300015fdfee111420162f346e5f
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Sep 14 19:30:03 2009 +0100

    Setup nspluginwrapper if available
    
and then added to the WebKit2 version in:

commit 09f082567a909bc9369f57a2e14b28846057814e
Author: Xan Lopez <xan@igalia.com>
Date:   Wed Mar 13 15:51:30 2013 +0100

    ephy-embed-single: also initialize nspluginwrapper plugins in WebKit2
    
    Should not be as important as in WebKit1, but no reason to not do it.

And now we have:
embed/ephy-embed-shell.c:    g_spawn_command_line_sync (NSPLUGINWRAPPER_SETUP, NULL, NULL, NULL, NULL);

<hadess> this is ancient
<hadess> yes, it needs to be sync
<hadess> i'm not sure it's needed any more though
<hadess> this was for "wrap 32-bit flash on 64 bit browsers"
<hadess> i would revert it
Comment 1 Bastien Nocera 2013-12-19 17:38:36 UTC 
Created attachment 264557 [details] [review]
Revert "ephy-embed-single: also initialize nspluginwrapper plugins in WebKit2"

The only plugin nspluginwrapper could really handle was Flash. Flash has
had a 64-bit version for a while, and isn't available separately from
Google Chrome any more. So, nspluginwrapper doesn't have anything to
support, ergo, let's remove nspluginwrapper support.

This reverts commit 09f082567a909bc9369f57a2e14b28846057814e.
Comment 2 Claudio Saavedra 2013-12-30 13:50:56 UTC 
Review of attachment 264557 [details] [review]:

Seems like a good idea.
Comment 3 William Jon McCann 2014-01-07 16:35:56 UTC 
Attachment 264557 [details] pushed as 6044c95 - Revert "ephy-embed-single: also initialize nspluginwrapper plugins in WebKit2"