GNOME Bugzilla – Bug 720736
Show a progress bar while loading diff
Last modified: 2018-05-22 13:09:30 UTC
So that we can know the status of the diff processing if we are displaying a large diff. The progress bar only reflects the progress of the hunks being processed, the last template replacement is not measured, so, there is still a lag after the progress bar is full.
Created attachment 264534 [details] [review] Remove an accident dot
Created attachment 264535 [details] [review] Improve the code format
Created attachment 264536 [details] [review] Show diff loading progress
Created attachment 264538 [details] Screenshot of the diff progress bar
Created attachment 264716 [details] [review] Fix round corner on the right side
See branch wip/techlivezh/fix-720726
Mistake, see branch wip/techlivezh/diff-progress-bar
Review of attachment 264536 [details] [review]: It's nice to show progress, but some general comments: 1) The tick_freq should maybe be tuned so that we get a nice progression on large commits 2) It will be hard to style the progress bar to look native. It would be good to have a designers opinion on this. To differentiate, we could also think of a different way to show the progress (fading, sliding?) 3) I would probably remove the whole loading diff text and only show the progress bar. ::: libgitg/resources/diff-view.js @@ +180,3 @@ { html_builder_tick = event.data.tick; + if($('progress')) Empty line before if. Space after if. @@ +182,3 @@ + if($('progress')) + { + $($('progress')[0]).attr('value',html_builder_tick); Space after comma
Review of attachment 264535 [details] [review]: Fine
Review of attachment 264534 [details] [review]: Fine
Created attachment 264864 [details] [review] Show diff loading progress
Created attachment 264865 [details] [review] Remove 'Loading diff...' text Progress bar should be sufficient.
(In reply to comment #8) > Review of attachment 264536 [details] [review]: > > It's nice to show progress, but some general comments: > > 1) The tick_freq should maybe be tuned so that we get a nice progression on > large commits Current tick_freq seems fine. > 2) It will be hard to style the progress bar to look native. It would be good > to have a designers opinion on this. To differentiate, we could also think of a > different way to show the progress (fading, sliding?) What does a native Gtk+ style progress bar look like? > 3) I would probably remove the whole loading diff text and only show the > progress bar. Done in a separate commit. > > ::: libgitg/resources/diff-view.js > @@ +180,3 @@ > { > html_builder_tick = event.data.tick; > + if($('progress')) > > Empty line before if. Space after if. Done > > @@ +182,3 @@ > + if($('progress')) > + { > + $($('progress')[0]).attr('value',html_builder_tick); > > Space after comma Done
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gitg/issues/27.