Created attachment 264524 [details] [review]
Show detached head in the commit list

Review of attachment 264524 [details] [review]:

Don't you get duplicate entries when HEAD is an actual branch (like master)?

Nope, no duplicate entries.

See branch wip/techlivezh/shoe-detached-head

Ah ok, I was missing some context there. So still, this will result in duplicate references to check for libgit2 (in the end), which doesn't look clean (it's also not straightforward to understand why you would also need to add head() still). So, please add a condition on repo.is_head_detached() before adding it to d_all.

(In reply to comment #5)
> Ah ok, I was missing some context there. So still, this will result in
> duplicate references to check for libgit2 (in the end), which doesn't look
> clean (it's also not straightforward to understand why you would also need to
> add head() still). So, please add a condition on repo.is_head_detached() before
> adding it to d_all.

Yeah, make sense, will see if this can be improved.

Created attachment 264868 [details] [review]
Show detached head in the commit list

Review of attachment 264868 [details] [review]:

Go ahead

Landed in commit c1757df