GNOME Bugzilla – Bug 720672
Default external container sort_by_criteria: Title name
Last modified: 2014-05-01 08:58:01 UTC
Created attachment 264473 [details] [review]
empty default sort_criteria for external containers
The default external container sort_by_criteria is Title name.
In my opinion, by default, it should not resort the results from the media server, thus, sort_by_criteria should be empty for external containers.
well. It should be something useful. Would it be better if the DBus spec provided some means to indicate how the container would like to be sorted or can provide it's own sort order?
Extending the DBus spec was my first thought, too.
We did discuss that topic on the mailing list and you said at some point you'd want the dLeyna extensions to be implemented at some point anyway. The dLeyna extensions specify a way of typing containers, which in turn would allow Rygel to specify a sort criterion per type.
However, I feel a bit different about the issue now. In my mind, the external plugin is not the same as for example the tracker. Rygel is responsible for presenting the tracker results and, thus, needs to be in charge of the sorting as well. The external plugin takes the result from a different process through the DBus interface. That process (e.g. Rhythmbox) already has a clear idea what item and container types it deals with and sorts them accordingly. Reordering that result by default is therefore wrong in my opinion.
I hope that made sense.