GNOME Bugzilla – Bug 720628
Print to existing file gui missing a button
Last modified: 2014-05-14 06:59:44 UTC
I'm running gnumeric 1.12.9, but I'm pretty sure that this problem has been around for a while. In any event, if I try to print to an existing file, I (correctly) get a pop-up telling me that the file "xxx.pdf" exists and do I want to replace it. The pop-up only has a cancel button. For what it's worth, as similar pop-up when exporting as a pdf file works as expected.
I can't reproduce, I see the two expected buttons.
Hmm, which gtk+ version do you use?
I'm using the current development release; i.e., 3.11.2. (Although I suspect, I'll be upgrading to 11.3 tomorrow :)). As I mentioned this has happened for a while, and I follow the development releases of gtk+.
It does not happen for me with gtk+-3.8.6, and this dialog is provided by gtk+ as far as I know. We don't call it directly.
Interesting. It doesn't happen here if I use data->export->export to other format and choose pdf (i.e., it works as expected). Shouldn't the same dialog be used for this and print to file?
Doesn't happen here with 3.8.7; the win32 binary under wine doesn't give me a print dialog at all.
The print-to-file dialog is in gtk+, not in gnumeric. Tossing to gtk+ under the assumption that the problem resides there.
This also happens with recent GTK+ 3.10.6 (Fedora 20).
Created attachment 266743 [details] [review] Show "Replace" button when printing to existing file I can confirm that this bug was introduced in gtk+-3.10. Function gtk_widget_show(), which shows the button, was accidentally removed. Attached is a patch which returns the gtk_widget_show() back. The patch is intended for gtk-3-10 branch, I'll attach another one for master. Marek
Created attachment 266745 [details] [review] Show "Replace" button when printing to existing file (master) Attached is a patch which fixes this in master. It uses gtk_dialog_add_button() for addition of the "Replace" button instead of custom function add_custom_button_to_dialog().
I don't know if the patch in comment 10 is the one mentioned in comment 9 for the master. In any event, I tried it and the patch fails in gtk+-3.11.4: patch -p1 --dry-run < ~/0001-printing-Show-Replace-button-when-printing-3-12.patch patching file gtk/gtkprintunixdialog.c Hunk #1 succeeded at 604 (offset -3 lines). Hunk #2 FAILED at 670. 1 out of 2 hunks FAILED -- saving rejects to file gtk/gtkprintunixdialog.c.rej
I've just tried "git am -3 ../0001-printing-Show-Replace-button-when-printing-3-12.patch" on git master and it was applied successfully.
I'm not on the git/master; I'm using the 3.11.4 tarball (cf. comment 11).
Created attachment 266846 [details] [review] Show "Replace" button when printing to existing file (3.11.4) (In reply to comment #13) > I'm not on the git/master; I'm using the 3.11.4 tarball (cf. comment 11). OK, here is version for 3.11.4.
It worked. Thanks!
Review of attachment 266846 [details] [review]: sure
Comment on attachment 266745 [details] [review] Show "Replace" button when printing to existing file (master) Thank you for the review. I've pushed the version for master to master. Can I push also the version for 3.10 to 3.10?
sure, please push to 3.10 as well (sadly it just missed a release I did earlier today)
Comment on attachment 266743 [details] [review] Show "Replace" button when printing to existing file (In reply to comment #18) > sure, please push to 3.10 as well (sadly it just missed a release I did earlier > today) Thank you. I've pushed it to 3-10.
*** Bug 724605 has been marked as a duplicate of this bug. ***
*** Bug 730104 has been marked as a duplicate of this bug. ***