GNOME Bugzilla – Bug 720605
commit-after_tweaks patch status
Last modified: 2015-01-04 14:46:24 UTC
often times a patch is substantially okay, but may need minor changes (say whitespace fixes or a better commit message). When this happens the patch either gets the "Reviewed" status or the "accept-commit_now" status. The latter means these patches get globbed into a pool along some patches that aren't really close to committable, and the latter puts them into a pool where they may get pushed accidentally without the tweaks. What would be good is a status "commit-after_tweaks" that can be used for this purpose.
IMHO "Reviewed" should die, as it means nothing (well, it means "I've seen this but I don't tell you what I think about it"). And "needs-work" already exists, and this sounds like a case for "needs-work" because it needs some more tweaks. Or? I don't want to differentiate to death by creating subsets of already existing statuses.
*** This bug has been marked as a duplicate of bug 684032 ***
weird that i filed this twice.
(In reply to comment #1) > And "needs-work" already exists, and this sounds like a case for "needs-work" > because it needs some more tweaks. needs-work isn't really appropriate because needs-work implies another round of review is required. It should be possible for a developer to query which patches are "ready to commit" and also for a developer to query which patches "are ready to commit after minor changes". And the list of patches needing non-negligible fix ups shouldn't get mixed into the bunch since they aren't relevant near release day. Anyway, i'm not going to argue too hard. status quo has worked.