After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720577 - libyelp exports private symbols
libyelp exports private symbols
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-16 23:40 UTC by Robert Ancell
Modified: 2015-01-28 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libyelp: Don't export private symbols (748 bytes, patch)
2013-12-16 23:43 UTC, Robert Ancell
none Details | Review
make private functions static (2.85 KB, patch)
2014-08-01 17:35 UTC, David King
committed Details | Review

Description Robert Ancell 2013-12-16 23:40:59 UTC
libyelp exports some private symbols, e.g.
 find_real_sibling
 find_real_top
 get_menuoptions
 icon_names
 info_process_text_notes
 resolve_frag_id
 str_refs

The easiest way to stop this is to get ld to only export symbols with the yelp_ prefix (patch attached).
Comment 1 Robert Ancell 2013-12-16 23:43:44 UTC
Created attachment 264376 [details] [review]
libyelp: Don't export private symbols
Comment 2 David King 2014-08-01 17:35:18 UTC
Created attachment 282289 [details] [review]
make private functions static

Marking the functions as static has a similar effect.
Comment 3 David King 2015-01-28 11:49:16 UTC
Review of attachment 282289 [details] [review]:

Acked by Shaun today, and pushed.