After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720520 - Remove analytics from browsed URLs
Remove analytics from browsed URLs
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-16 10:14 UTC by Bastien Nocera
Modified: 2014-01-13 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
lib: Add helper to remove tracking from URIs (12.57 KB, patch)
2013-12-16 10:15 UTC, Bastien Nocera
none Details | Review
Remove analytics from browsed URLs (1.35 KB, patch)
2013-12-16 10:15 UTC, Bastien Nocera
none Details | Review
lib: Add helper to remove tracking from URIs (12.36 KB, patch)
2013-12-16 15:10 UTC, Bastien Nocera
reviewed Details | Review
Remove analytics from browsed URLs (1.97 KB, patch)
2014-01-10 14:04 UTC, Bastien Nocera
reviewed Details | Review
Remove analytics from browsed URLs (2.53 KB, patch)
2014-01-13 09:22 UTC, Bastien Nocera
committed Details | Review
lib: Add helper to remove tracking from URIs (12.60 KB, patch)
2014-01-13 11:56 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2013-12-16 10:14:58 UTC
.
Comment 1 Bastien Nocera 2013-12-16 10:15:01 UTC
Created attachment 264269 [details] [review]
lib: Add helper to remove tracking from URIs

This function, based on the PureURL Firefox add-on, will strip
tracking information from URLs, such as analytics information.

See https://addons.mozilla.org/fr/firefox/addon/pure-url/
Comment 2 Bastien Nocera 2013-12-16 10:15:06 UTC
Created attachment 264270 [details] [review]
Remove analytics from browsed URLs

When using "Do not track", also remove analytics information
from URLs using the new URI helper.
Comment 3 Bastien Nocera 2013-12-16 10:30:35 UTC
I've not actually tested the 2nd patch, but the first one passes all its tests.
Comment 4 Bastien Nocera 2013-12-16 15:10:24 UTC
Created attachment 264290 [details] [review]
lib: Add helper to remove tracking from URIs

This function, based on the PureURL Firefox add-on, will strip
tracking information from URLs, such as analytics information.

See https://addons.mozilla.org/fr/firefox/addon/pure-url/
Comment 5 Carlos Garcia Campos 2013-12-22 08:27:47 UTC
Review of attachment 264270 [details] [review]:

::: src/ephy-window.c
@@ +2172,3 @@
+		if (new_uri)
+			webkit_uri_request_set_uri (request, new_uri);
+		g_free (new_uri);

hmm, the idea is to remove the garbage before sending the url to the server or after? Because at this point the url has already been sent. I think the best place for this would be the send-request signal unless I'm not understanding how this is supposed to work.
Comment 6 Bastien Nocera 2014-01-10 14:04:30 UTC
Created attachment 265922 [details] [review]
Remove analytics from browsed URLs

When using "Do not track", also remove analytics information
from URLs using the new URI helper.
Comment 7 Carlos Garcia Campos 2014-01-11 12:44:18 UTC
Review of attachment 264290 [details] [review]:

LGTM

::: lib/Makefile.am
@@ +69,3 @@
 	ephy-string.c				\
 	ephy-time-helpers.c			\
+	ephy-uri-helpers.c			\

This will only be used by the web extension, so I think we could build it only with the extension, and also for the test.

::: lib/ephy-uri-helpers.c
@@ +1,1 @@
+/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*- */

New files should use the new coding style, see HACKING file.

@@ +93,3 @@
+{
+	g_return_if_fail (name != NULL);
+	g_return_if_fail (value != NULL);

Use assert instead of g_return macros for private functions, or simply remove them.
Comment 8 Carlos Garcia Campos 2014-01-11 12:50:01 UTC
Review of attachment 265922 [details] [review]:

I wonder how this works, because in your previous patch the uri helpers file is compiled in libephymisc, but the web extension doesn't link to libephymisc. I think you have to include the rui helpers file as source code of the web extension directly. Patch looks good to me.
Comment 9 Bastien Nocera 2014-01-13 09:22:59 UTC
Created attachment 266138 [details] [review]
Remove analytics from browsed URLs

When using "Do not track", also remove analytics information
from URLs using the new URI helper.
Comment 10 Bastien Nocera 2014-01-13 11:56:55 UTC
Created attachment 266152 [details] [review]
lib: Add helper to remove tracking from URIs

This function, based on the PureURL Firefox add-on, will strip
tracking information from URLs, such as analytics information.

See https://addons.mozilla.org/fr/firefox/addon/pure-url/
Comment 11 Carlos Garcia Campos 2014-01-13 12:17:33 UTC
Review of attachment 266152 [details] [review]:

Ok
Comment 12 Carlos Garcia Campos 2014-01-13 12:18:05 UTC
Review of attachment 266138 [details] [review]:

Perfect, thanks!
Comment 13 Bastien Nocera 2014-01-13 17:33:23 UTC
Attachment 266138 [details] pushed as 00946ff - Remove analytics from browsed URLs
Attachment 266152 [details] pushed as 7f09ee3 - lib: Add helper to remove tracking from URIs