GNOME Bugzilla – Bug 720520
Remove analytics from browsed URLs
Last modified: 2014-01-13 17:33:30 UTC
.
Created attachment 264269 [details] [review] lib: Add helper to remove tracking from URIs This function, based on the PureURL Firefox add-on, will strip tracking information from URLs, such as analytics information. See https://addons.mozilla.org/fr/firefox/addon/pure-url/
Created attachment 264270 [details] [review] Remove analytics from browsed URLs When using "Do not track", also remove analytics information from URLs using the new URI helper.
I've not actually tested the 2nd patch, but the first one passes all its tests.
Created attachment 264290 [details] [review] lib: Add helper to remove tracking from URIs This function, based on the PureURL Firefox add-on, will strip tracking information from URLs, such as analytics information. See https://addons.mozilla.org/fr/firefox/addon/pure-url/
Review of attachment 264270 [details] [review]: ::: src/ephy-window.c @@ +2172,3 @@ + if (new_uri) + webkit_uri_request_set_uri (request, new_uri); + g_free (new_uri); hmm, the idea is to remove the garbage before sending the url to the server or after? Because at this point the url has already been sent. I think the best place for this would be the send-request signal unless I'm not understanding how this is supposed to work.
Created attachment 265922 [details] [review] Remove analytics from browsed URLs When using "Do not track", also remove analytics information from URLs using the new URI helper.
Review of attachment 264290 [details] [review]: LGTM ::: lib/Makefile.am @@ +69,3 @@ ephy-string.c \ ephy-time-helpers.c \ + ephy-uri-helpers.c \ This will only be used by the web extension, so I think we could build it only with the extension, and also for the test. ::: lib/ephy-uri-helpers.c @@ +1,1 @@ +/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8 -*- */ New files should use the new coding style, see HACKING file. @@ +93,3 @@ +{ + g_return_if_fail (name != NULL); + g_return_if_fail (value != NULL); Use assert instead of g_return macros for private functions, or simply remove them.
Review of attachment 265922 [details] [review]: I wonder how this works, because in your previous patch the uri helpers file is compiled in libephymisc, but the web extension doesn't link to libephymisc. I think you have to include the rui helpers file as source code of the web extension directly. Patch looks good to me.
Created attachment 266138 [details] [review] Remove analytics from browsed URLs When using "Do not track", also remove analytics information from URLs using the new URI helper.
Created attachment 266152 [details] [review] lib: Add helper to remove tracking from URIs This function, based on the PureURL Firefox add-on, will strip tracking information from URLs, such as analytics information. See https://addons.mozilla.org/fr/firefox/addon/pure-url/
Review of attachment 266152 [details] [review]: Ok
Review of attachment 266138 [details] [review]: Perfect, thanks!
Attachment 266138 [details] pushed as 00946ff - Remove analytics from browsed URLs Attachment 266152 [details] pushed as 7f09ee3 - lib: Add helper to remove tracking from URIs