After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720492 - Letter spacing in Text Tool not reset to default
Letter spacing in Text Tool not reset to default
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.8.2
Other All
: Normal normal
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2013-12-15 15:04 UTC by saulgoode
Modified: 2013-12-21 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to reset Text Tool letter spacing (873 bytes, patch)
2013-12-20 23:01 UTC, saulgoode 		none Details | Review

Description saulgoode 2013-12-15 15:04:25 UTC 
The letter spacing entry widget's value should reset to "0.0" when the "Reset to default values" button is clicked in the Text Tool Options dialog (or when that button is clicked while the SHIFT key is held down within any other Tool Options dialog). This does not happen; the value for letter spacing remains unchanged after a reset has been performed.
Comment 1 Michael Natterer 2013-12-17 18:02:41 UTC 
Thanks, this is essentially bug 631934.

*** This bug has been marked as a duplicate of bug 631934 ***
Comment 2 saulgoode 2013-12-18 05:57:57 UTC 
Perhaps I am misunderstanding the nature of bug 631934, but *this* bug's existence can be attributed to a simple omission of a call to reset the "letter-spacing" property within the 'gimp_text_options_reset()' function* (defined in app/tools/gimptextoptions.c).

In my opinion, the resolution of this bug should entail nothing more than the insertion of the following line into that function:

  gimp_config_reset_property (object, "letter-spacing");

This modification could be done without it being necessary to take into consideration any of the other issues discussed in bug 631934.



* https://git.gnome.org/browse/gimp/tree/app/tools/gimptextoptions.c#n361
Comment 3 Michael Natterer 2013-12-18 08:53:41 UTC 
You are so right...
Comment 4 Jehan 2013-12-20 02:07:06 UTC 
Hi saulgoode,

I have not checked the code at all, but you seem to be a developer and to know what is to be changed. Of course someone else may look and fix this sooner or later, but if you were to provide a solid patch for the issue (with `git format-patch origin/master`), I'm sure we would welcome it. :-)
Thanks.
Comment 5 Michael Natterer 2013-12-20 12:14:27 UTC 
Fixed in master and gimp-2-8:

commit db602b3b3328275359e5714df33ae449e6e93774
Author: Michael Natterer <mitch@gimp.org>
Date:   Fri Dec 20 13:11:53 2013 +0100

    Bug 720492 - Letter spacing in Text Tool not reset to default
    
    Also reset the "letter-spacing" property in gimp_text_options_reset().
    
    (cherry picked from commit 81c02e7db1fa96ec6b7f0e84d4bc8b9ce2dca293)

 app/tools/gimptextoptions.c | 1 +
 1 file changed, 1 insertion(+)
Comment 6 saulgoode 2013-12-20 23:01:22 UTC 
Created attachment 264650 [details] [review]
Patch to reset Text Tool letter spacing

Here is the patch to add the line. I have not had the chance to text it yet but will try to do that in the next few days.
Comment 7 saulgoode 2013-12-20 23:04:51 UTC 
Ignore comment #6 (I should have refreshed my browser and/or checked the commit log before submitting).
Comment 8 Michael Natterer 2013-12-21 09:11:01 UTC 
Same here, I didn't see Jehan's question for a patch either :)