After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720470 - Introspection revamp and build fix for FreeBSD
Introspection revamp and build fix for FreeBSD
Product: gtk-vnc
Classification: Other
Component: general
Other FreeBSD
: Normal normal
: ---
Assigned To: gtk-vnc-maint
Depends on:
Reported: 2013-12-14 22:52 UTC by Koop Mast (kwm)
Modified: 2014-01-23 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Introspection reworked (13.80 KB, patch)
2013-12-14 22:52 UTC, Koop Mast (kwm)
reviewed Details | Review
include stddef.h for size_t on FreeBSD (517 bytes, patch)
2013-12-14 22:53 UTC, Koop Mast (kwm)
accepted-commit_now Details | Review
Update patch. (9.61 KB, patch)
2013-12-29 19:19 UTC, Koop Mast (kwm)
none Details | Review
Introspection patch update. (9.74 KB, patch)
2014-01-18 13:38 UTC, Koop Mast (kwm)
none Details | Review

Description Koop Mast (kwm) 2013-12-14 22:52:32 UTC
Created attachment 264202 [details] [review]
Introspection reworked

Introspection support doesn't work on FreeBSD. Ryan Lortie said that there is a general way of doing introspection instead of doing it by hand.

I used the following documentation to impliment this. While it works for me, I not quite sure if it all done correctly.
Comment 1 Koop Mast (kwm) 2013-12-14 22:53:22 UTC
Created attachment 264203 [details] [review]
include stddef.h for size_t on FreeBSD
Comment 2 Allison Karlitskaya (desrt) 2013-12-15 00:48:17 UTC
Review of attachment 264202 [details] [review]:

It's unusual to put the .m4 of introspection under source control.  Usually it's better to just have gobject-introspection as a hard build dependency when building from git (which will result in the m4 being found in the system's aclocal and automatically copied in and included in the tarball).

The --enable-introspection in the Makefile also seems suspicious.  This should probably be on by default...
Comment 3 Allison Karlitskaya (desrt) 2013-12-15 01:01:03 UTC
Review of attachment 264202 [details] [review]:

Sorry.  Wrong status :)
Comment 4 Allison Karlitskaya (desrt) 2013-12-15 01:01:52 UTC
Comment on attachment 264202 [details] [review]
Introspection reworked

Sorry.  Wrong status :)
Comment 5 Allison Karlitskaya (desrt) 2013-12-28 19:20:55 UTC
Review of attachment 264203 [details] [review]:

This is harmless.  Please commit it now.

Any word on getting an updated patch for the other one?
Comment 6 Koop Mast (kwm) 2013-12-29 19:19:58 UTC
Created attachment 265002 [details] [review]
Update patch.
Comment 7 Koop Mast (kwm) 2014-01-18 13:38:48 UTC
Created attachment 266609 [details] [review]
Introspection patch update.

This patch has two additional fixes.
1) Gtkvnc-gir needs Gvnc-gir to be build first. So register the dependency.
2) Attempt to fix the gir build with jobs enabled.
Comment 8 Daniel P. Berrange 2014-01-23 12:12:35 UTC
Fixed in 3 commits.

commit ff7b8c29d2efd8e0262d76457ed8302397c84148
Author: Daniel P. Berrange <>
Date:   Thu Jan 23 12:11:08 2014 +0000

    Fix parallel build of introspection gir files

commit 6359563b7b83e958be53dd6efbbac899802edfc3
Author: Koop Mast <>
Date:   Sat Dec 14 23:36:24 2013 +0100

    Rework introspection support so it works on FreeBSD.
commit 16b5ed3e4237668a8f352c0a1408e2460c5c1e89
Author: Koop Mast <>
Date:   Sat Dec 14 23:27:11 2013 +0100

    Add stddef.h for size_t on FreeBSD.