After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720434 - srtp: add 256-bit keys support
srtp: add 256-bit keys support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-13 22:16 UTC by Aleix Conchillo Flaqué
Modified: 2013-12-13 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add 256 bit key support (7.59 KB, patch)
2013-12-13 22:22 UTC, Aleix Conchillo Flaqué
committed Details | Review

Description Aleix Conchillo Flaqué 2013-12-13 22:16:13 UTC
Currently, srtpenc and srtpdec only support AES-128. libSRTP also support 256-bit keys so it would be great to have that available as well.
Comment 1 Aleix Conchillo Flaqué 2013-12-13 22:22:42 UTC
Created attachment 264172 [details] [review]
add 256 bit key support
Comment 2 Olivier Crête 2013-12-13 22:58:45 UTC
Pushed

commit fefd021ee2916531b8c0698c14787c2e810e9324
Author: Aleix Conchillo Flaqué <aleix@oblong.com>
Date:   Fri Dec 13 14:16:49 2013 -0800

    srtp: add 256-bit key support
    
    * ext/srtp/gstsrtp.[ch]: added GST_SRTP_CIPHER_AES_256_ICM to
      GstSrtpCipherType and new function cipher_key_size.
    
    * ext/srtp/gstsrtpenc.c: maximum key size is now 46 characters (14 for
      the salt plus the key). If different ciphers are chosen for RTP and
      RTCP the maximum needed key size is expected.
    
    * ext/srtp/gstsrtpdec.c: minor documentation updates.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720434