GNOME Bugzilla – Bug 720410
GPL license link doesn't specify "or later"
Last modified: 2013-12-16 16:45:38 UTC
When an application uses, for example: "license-type", GTK_LICENSE_GPL_2_0, There is no way to specify whether it includes "or later" versions.
The current short text doesn't really lend itself to adding license version information: This program comes with ABSOLUTELY NO WARRANTY; for details see http://... No place to put 'or later' here, and there's no good url for GPLv2 'or later'.
Created attachment 264298 [details] [review] about dialog: differentiate GPL "or later" versions
Created attachment 264299 [details] [review] about dialog: differentiate GPL "or later" versions Remember to translate the name.
Created attachment 264300 [details] screenshot
Review of attachment 264298 [details] [review]: ::: gtk/gtkaboutdialog.c @@ +96,3 @@ /* Translators: this is the license preamble; the string at the end * contains the URL of the license. */ Should probably update the translator comment to state that the name of the license will be displayed as link text @@ +107,3 @@ +/* URLs for each GtkLicense type; keep in the same order as the enumeration */ +static const LicenseInfo gtk_license_info [] = { + { N_("Unknown"), NULL }, If unknown ever ends up as link text in the ui, that'll probably look odd - might be better to say _("License") ? @@ +108,3 @@ +static const LicenseInfo gtk_license_info [] = { + { N_("Unknown"), NULL }, + { N_("Custom License") , NULL }, This will never show up in the ui, right ? May save translator work by not marking it
Created attachment 264304 [details] [review] about dialog: differentiate GPL "or later" versions
Review of attachment 264304 [details] [review]: thanks, looks good to me now