After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720375 - vaapipostproc: fix support for deinterlacing while seeking
vaapipostproc: fix support for deinterlacing while seeking
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Windows
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 720305
 
 
Reported: 2013-12-13 06:30 UTC by Zhao, Halley
Modified: 2014-06-18 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-vaapipostproc-fixes (2.26 KB, patch)
2013-12-13 06:31 UTC, Zhao, Halley
none Details | Review
0002-vaapipostproc-optimize-for-bob-deinterlace-only (2.20 KB, patch)
2013-12-13 06:32 UTC, Zhao, Halley
none Details | Review
0003-vaapipostproc-skip-weave-deinterlace (1.42 KB, patch)
2013-12-13 06:32 UTC, Zhao, Halley
none Details | Review
0004-vaapipostproc-update-advanced-deinterlace-when-there (3.04 KB, patch)
2013-12-13 06:32 UTC, Zhao, Halley
none Details | Review

Description Zhao, Halley 2013-12-13 06:30:13 UTC
GstVaapiDeinterlaceState requires reset when there is discontinuity.
for example: the cached previous frame is not valid after seek.
Comment 1 Zhao, Halley 2013-12-13 06:31:53 UTC
Created attachment 264118 [details] [review]
0001-vaapipostproc-fixes
Comment 2 Zhao, Halley 2013-12-13 06:32:12 UTC
Created attachment 264119 [details] [review]
0002-vaapipostproc-optimize-for-bob-deinterlace-only
Comment 3 Zhao, Halley 2013-12-13 06:32:30 UTC
Created attachment 264120 [details] [review]
0003-vaapipostproc-skip-weave-deinterlace
Comment 4 Zhao, Halley 2013-12-13 06:32:44 UTC
Created attachment 264121 [details] [review]
0004-vaapipostproc-update-advanced-deinterlace-when-there
Comment 5 Gwenole Beauchesne 2014-06-18 15:35:38 UTC
commit faefd62e9be3e36cc0465f5e66e1711d7b5d7a03
Author: Zhao, Halley <halley.zhao@intel.com>
Date:   Thu Dec 12 10:01:13 2013 +0800

    vaapipostproc: reset deinterlacer state when there is a discontinuity.
    
    Reset deinterlacer state, i.e. past reference frames used for advanced
    deinterlacing, when there is some discontinuity detected in the course
    of processing source buffers.
    
    This fixes support for advanced deinterlacing when a seek occurred.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720375
    
    [fixed type of pts_diff variable, fetch previous buffer PTS from the
     history buffer, reduce heuristic for detecting discontinuity]
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>