After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720369 - Build failure on 0.20.8 with --enable-debug
Build failure on 0.20.8 with --enable-debug
Status: RESOLVED FIXED
Product: GUPnP
Classification: Other
Component: gupnp
0.20.x
Other Linux
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-13 02:05 UTC by Craig Pratt
Modified: 2013-12-14 14:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ignore deprecation warning when in a deprecated function (1.21 KB, patch)
2013-12-13 12:29 UTC, Jussi Kukkonen 		none Details | Review
Ignore deprecation warning when in a deprecated function (1.22 KB, patch)
2013-12-13 14:40 UTC, Jussi Kukkonen 		committed Details | Review

Description Craig Pratt 2013-12-13 02:05:36 UTC 
Seeing the following build failure when building gupnp with --enable-debug on commit 78b3f02d:

  CC       gupnp-service-proxy.lo
gupnp-service-proxy.c: In function 'gupnp_service_proxy_send_action_hash':
gupnp-service-proxy.c:658:9: error: 'gupnp_service_proxy_begin_action_hash' is deprecated (declared at gupnp-service-proxy.h:181) [-Werror=deprecated-declarations]

Building is successful without --enable-debug

Let me know if you need more info...
Comment 1 Jussi Kukkonen 2013-12-13 12:29:48 UTC 
Created attachment 264139 [details] [review]
Ignore deprecation warning when in a deprecated function

The deprecated call is inside another deprecated function, so
we can use G_GNUC_*_IGNORE_DEPRECATIONS if we want to. Looks ugly
but works.
Comment 2 Jussi Kukkonen 2013-12-13 14:40:05 UTC 
Created attachment 264152 [details] [review]
Ignore deprecation warning when in a deprecated function

...I guess normal indentation makes sense for a macro.
Comment 3 Jens Georg 2013-12-14 14:57:41 UTC 
Review of attachment 264152 [details] [review]:

+1
Comment 4 Jens Georg 2013-12-14 14:59:10 UTC 
Attachment 264152 [details] pushed as 135a7de - Ignore deprecation warning when in a deprecated function