After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720338 - Crash when closing http connection to CUPS
Crash when closing http connection to CUPS
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-12-12 17:21 UTC by Marek Kašík
Modified: 2013-12-14 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't double free connection to CUPS (1.52 KB, patch)
2013-12-12 17:21 UTC, Marek Kašík 		committed Details | Review

Description Marek Kašík 2013-12-12 17:21:49 UTC 
Created attachment 264093 [details] [review]
Don't double free connection to CUPS

It seems that it can happen that http connection to CUPS is freed twice according backtrace in these two bugs: https://bugzilla.redhat.com/show_bug.cgi?id=985272 and https://bugzilla.redhat.com/show_bug.cgi?id=1039766.
Unfortunately, I'm not able to simulate the problem now.

The only way how this could happen (at least I think so) is that the connection which was created outside of GtkCupsRequest's functions is closed in a GtkCupsRequest function (_post_check or _get_check in this case).

Gtk's CUPS module already has a mechanism for handling this. It is a boolean named "own_http" in GtkCupsRequest. The attached patch checks this boolean before closing the connection in _post_check and _get_check.

Marek