After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720319 - Fix instantiation from control-center
Fix instantiation from control-center
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openswan (deprecated)
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-12 12:37 UTC by Bastien Nocera
Modified: 2014-03-05 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix instantiation from control-center (1.51 KB, patch)
2013-12-12 12:38 UTC, Bastien Nocera
reviewed Details | Review
Fix instantiation from control-center (36.69 KB, patch)
2014-01-08 15:48 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2013-12-12 12:37:52 UTC
.
Comment 1 Bastien Nocera 2013-12-12 12:38:06 UTC
Created attachment 264063 [details] [review]
Fix instantiation from control-center

->get_widget() was returning a widget that already had a parent
instead of a stand-alone widget which we could pack as we pleased.

This fixes the IPSec VPN dialogue in gnome-control-center's Network
panel not working.

See https://bugzilla.redhat.com/show_bug.cgi?id=1040924
Comment 2 Dan Winship 2013-12-23 22:15:08 UTC
Comment on attachment 264063 [details] [review]
Fix instantiation from control-center

I think it would be more consistent with the other plugins to just remove the toplevel window.

(And "consistent with the other plugins" is good because it makes it easier to do across-the-board changes.)
Comment 3 Bastien Nocera 2014-01-07 13:34:57 UTC
(In reply to comment #2)
> (From update of attachment 264063 [details] [review])
> I think it would be more consistent with the other plugins to just remove the
> toplevel window.
> 
> (And "consistent with the other plugins" is good because it makes it easier to
> do across-the-board changes.)

I think that we've already had this discussion. The .ui file isn't a stand-alone file to be reused where it pleases, it's supposed to be instantiated through the plugin's helpers. So it shouldn't really make any difference whether the change is in code or the UI definition file.

It's also easier to read than the -300/+300 diff. Do you want that as a patch (select openswan-vbox in glade, remove parent, save)?
Comment 4 Dan Williams 2014-01-07 19:42:49 UTC
I'd prefer the toplevel removal in the .ui file FWIW; the only reason there was a toplevel was because either (a) glade from 2007 required it, or (b) I was originally stupid.  Maybe both are true.  But there's no reason to keep it around now.
Comment 5 Bastien Nocera 2014-01-08 15:48:57 UTC
Created attachment 265714 [details] [review]
Fix instantiation from control-center

->get_widget() was returning a widget that already had a parent
instead of a stand-alone widget which we could pack as we pleased.

This fixes the IPSec VPN dialogue in gnome-control-center's Network
panel not working.

See https://bugzilla.redhat.com/show_bug.cgi?id=1040924
Comment 6 Dan Williams 2014-03-05 17:33:10 UTC
Pushed to git master and nm-0-9-8.