GNOME Bugzilla – Bug 720319
Fix instantiation from control-center
Last modified: 2014-03-05 17:33:10 UTC
.
Created attachment 264063 [details] [review] Fix instantiation from control-center ->get_widget() was returning a widget that already had a parent instead of a stand-alone widget which we could pack as we pleased. This fixes the IPSec VPN dialogue in gnome-control-center's Network panel not working. See https://bugzilla.redhat.com/show_bug.cgi?id=1040924
Comment on attachment 264063 [details] [review] Fix instantiation from control-center I think it would be more consistent with the other plugins to just remove the toplevel window. (And "consistent with the other plugins" is good because it makes it easier to do across-the-board changes.)
(In reply to comment #2) > (From update of attachment 264063 [details] [review]) > I think it would be more consistent with the other plugins to just remove the > toplevel window. > > (And "consistent with the other plugins" is good because it makes it easier to > do across-the-board changes.) I think that we've already had this discussion. The .ui file isn't a stand-alone file to be reused where it pleases, it's supposed to be instantiated through the plugin's helpers. So it shouldn't really make any difference whether the change is in code or the UI definition file. It's also easier to read than the -300/+300 diff. Do you want that as a patch (select openswan-vbox in glade, remove parent, save)?
I'd prefer the toplevel removal in the .ui file FWIW; the only reason there was a toplevel was because either (a) glade from 2007 required it, or (b) I was originally stupid. Maybe both are true. But there's no reason to keep it around now.
Created attachment 265714 [details] [review] Fix instantiation from control-center ->get_widget() was returning a widget that already had a parent instead of a stand-alone widget which we could pack as we pleased. This fixes the IPSec VPN dialogue in gnome-control-center's Network panel not working. See https://bugzilla.redhat.com/show_bug.cgi?id=1040924
Pushed to git master and nm-0-9-8.