What's a team connection?

(In reply to comment #1)
> What's a team connection?

It is very similar to bonding. In fact I think that the adding support for team connection type is very easy copy&paste exercise.

Jiri

Created attachment 264147 [details] [review]
[PATCH] network: add Team to g-c-c connection editor

The patch adds support for adding Team connection in gnome-control-center
(click "+" button)

Review of attachment 264147 [details] [review]:

The code looks like it's the exact same as the bond and bridge code.

I would simplify this, and make the net-device-bond code more generic and do checks like:
if (NM_IS_DEVICE_BRIDGE (object))
  slaves = nm_device_bridge_get_slaves (object);
else if (NM_IS_DEVICE_BOND (object))
  etc.

This patch looks find to commit to gnome-3-8 and gnome-3-10 though.

::: panels/network/net-device-team.c
@@ +100,3 @@
+        slaves = nm_device_team_get_slaves (nm_device);
+        if (!slaves) {
+                priv->slaves = g_strdup ("(none)");

Translation?
Though I see this is the same code as in the bond object.

Review of attachment 264147 [details] [review]:

Setting as reviewed.

(In reply to comment #4)
> Review of attachment 264147 [details] [review]:
> 
> The code looks like it's the exact same as the bond and bridge code.
> 
> I would simplify this, and make the net-device-bond code more generic and do
> checks like:
> if (NM_IS_DEVICE_BRIDGE (object))
>   slaves = nm_device_bridge_get_slaves (object);
> else if (NM_IS_DEVICE_BOND (object))
>   etc.
> 
Yeah, the team code is basically a copy of bond. Sure, it could be possible to make it more generic. However, the code paths may become different for bondxteamxbridge later. And I'm not familiar with the code much, so I'm not going to do that.

> This patch looks find to commit to gnome-3-8 and gnome-3-10 though.
> 
Will you handle that? I am not sure I have commit rights.

> ::: panels/network/net-device-team.c
> @@ +100,3 @@
> +        slaves = nm_device_team_get_slaves (nm_device);
> +        if (!slaves) {
> +                priv->slaves = g_strdup ("(none)");
> 
> Translation?
> Though I see this is the same code as in the bond object.

See next patch.

Created attachment 264409 [details] [review]
[patch] network: make "(none)" translatable

Review of attachment 264409 [details] [review]:

That looks fine for master. Please remove the signed-off-by in the commit message though.

Review of attachment 264147 [details] [review]:

Fine then, let's commit it.