After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720285 - bootstrap: get libtool as .tar.gz, not .tar.xz
bootstrap: get libtool as .tar.gz, not .tar.xz
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-12-11 20:36 UTC by Allison Karlitskaya (desrt)
Modified: 2013-12-16 21:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
bootstrap: get libtool as .tar.gz, not .tar.xz (1.69 KB, patch)
2013-12-11 20:36 UTC, Allison Karlitskaya (desrt)
none Details | Review
bootstrap: get autotools as .tar.gz, not .tar.xz (2.32 KB, patch)
2013-12-11 20:47 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2013-12-11 20:36:01 UTC
On Mac OS, we have none of libtool automake or xz in the base system.
xz depends on automake and automake depends on libtool, so we need to
download libtool as a .tar.gz to break the cycle.
Comment 1 Allison Karlitskaya (desrt) 2013-12-11 20:36:03 UTC
Created attachment 264008 [details] [review]
bootstrap: get libtool as .tar.gz, not .tar.xz
Comment 2 Allison Karlitskaya (desrt) 2013-12-11 20:36:47 UTC
Oh... and http is always nicer than ftp, if we can.
Comment 3 Allison Karlitskaya (desrt) 2013-12-11 20:47:31 UTC
Created attachment 264009 [details] [review]
bootstrap: get autotools as .tar.gz, not .tar.xz

On Mac OS, we have none of libtool automake or xz in the base system.
xz depends on automake and automake depends on libtool, so we need to
download libtool and automake as .tar.gz to break the cycle.

Also: use http instead of ftp, as it's more reliable.
Comment 4 John Ralls 2013-12-11 21:21:07 UTC
xz doesn't depend on anything, it's being built from a tarball and so already has a configure script. Just make it the first package and you can use xz for everything else.

This is what I do in Gtk-OSX: 
https://git.gnome.org/browse/gtk-osx/tree/modulesets-stable/bootstrap.modules
Comment 5 Allison Karlitskaya (desrt) 2013-12-11 21:25:10 UTC
By default jhbuild autogens tarballs.  I don't agree with it doing that, but this has been discussed before...
Comment 6 Allison Karlitskaya (desrt) 2013-12-11 21:32:38 UTC
So there is autogen-sh="configure" as an attribute on <autotools/>.  Adding this for xz might be good enough.  We'd have to rework the order of the deps in the bootstrap module to take that into account, though.
Comment 7 John Ralls 2013-12-11 22:26:21 UTC
(In reply to comment #6)
> So there is autogen-sh="configure" as an attribute on <autotools/>.  Adding
> this for xz might be good enough.  We'd have to rework the order of the deps in
> the bootstrap module to take that into account, though.

There is indeed, and if you'd followed the link you'd have seen that I do that in gtk-osx's bootstrap.

At some point GNU may quit shipping bz2s just like we have and you'll have to build xz first anyway. Might as well start now.
Comment 8 Colin Walters 2013-12-16 21:30:25 UTC
Review of attachment 264009 [details] [review]:

Hmmm.  Can't we also require the builder to install xz from ports first?

This patch should be harmless for now, but I suspect long term GNU is going to stop publishing the .gz versions, so it'll only be a short term fix.  Anyways fine to commit for now.
Comment 9 Allison Karlitskaya (desrt) 2013-12-16 21:36:20 UTC
Attachment 264009 [details] pushed as 291f3bc - bootstrap: get autotools as .tar.gz, not .tar.xz


This is for the benefit of Mac OS, which doesn't have an official ports
system.  I'd rather sidestep the whole brew vs. macports vs. fink debate
if at all possible...