After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720265 - Wired 802.1x: only request new secrets during the initial connection [patch included]
Wired 802.1x: only request new secrets during the initial connection [patch i...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-11 15:45 UTC by Michael Schaller
Modified: 2014-01-22 09:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wired: only request new secrets during the initial connection (2.82 KB, patch)
2013-12-11 15:45 UTC, Michael Schaller 		none Details | Review

Description Michael Schaller 2013-12-11 15:45:38 UTC 
Created attachment 263991 [details] [review]
wired: only request new secrets during the initial connection

Hi everyone,

Dan Watson committed a patch [1] to let WiFi connections only request new secrets during the initial connection. I've ported this patch for wired connections.

Please let me know about the patch.

Best,

Michael Schaller


[1] http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=30fe3e18766367d159dfb16d7ca5559d7dc58b9a
Comment 1 Michael Schaller 2013-12-11 15:46:57 UTC 
Correction: Please let me know *what you think* about the patch.
Comment 2 Michael Schaller 2014-01-13 14:04:45 UTC 
Hi everyone,

A month has passed - or rather 2 weeks if we don't count Christmas and New Year. ;-)

So is there any comment on this small patch?

Best,

Michael
Comment 3 Dan Winship 2014-01-17 14:55:29 UTC 
makes sense to me, but an ack from dcbw would be good
Comment 4 Thomas Haller 2014-01-17 19:52:03 UTC 
btw, I have this patch currently on the branch th/miscellaneous -- I only reworded the commit message.

I too think it's good.
Comment 5 Thomas Haller 2014-01-21 20:28:14 UTC 
Patch pushed to master as http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=6b5d31954fa655b47a9928f61d34ca74f92a953e

Thanks Michael for your help.
Comment 6 Michael Schaller 2014-01-22 09:06:23 UTC 
Thank you Dan and Thomas.

While we are at it... Could you also give me feedback on my other 802.1x-related patch? https://bugzilla.gnome.org/show_bug.cgi?id=719982