GNOME Bugzilla – Bug 720206
Top bar - disclosure triangles aren't vertically centered
Last modified: 2014-02-19 14:29:59 UTC
Created attachment 263937 [details] modified screenshot The disclosure triangles in the top bar look out of alignment with the icons in the system status area. I've attached a screenshot; the bottom image has been modified by moving the arrows up a couple of pixels.
I think it looks better the way they are. With the current height they start at the middle ("vertically centered") and drop down. Perhaps we can ask one of the font experts around here...
Centring usually refers to the visual "centre of gravity" - ie. the middle of the object. Maybe I'm wrong though. CC'ing Jakub for a second opinion.
I also think that the arrows should be slightly larger; right now they look a little bit like an afterthought.
I think you went too far. Especially the text-only keyboard switcher now feels off balance to my eye. Going a 1px down would probably hit the sweet spot. I don't feel like enlarging would be a good thing either, unless we counter the increased weight with toning down the color.
FWIW, this is something neear for what Allan proposed. It is with ubuntu fonts: http://i.imgur.com/vhXN7zG.png But Allan propose to use an icon instead of rely on fonts for those. Can designers provide a svg for that with the desired size given a specific font size? (four arrow positions) and I will look into it this weekend. Thanks!
(In reply to comment #5) > FWIW, this is something neear for what Allan proposed. It is with ubuntu fonts: > http://i.imgur.com/vhXN7zG.png > > But Allan propose to use an icon instead of rely on fonts for those. Can > designers provide a svg for that with the desired size given a specific font > size? (four arrow positions) and I will look into it this weekend. Thanks! My main point is that the font shouldn't change UI elements. I doubt it should be an icon: seems more like it should be a part of the theme.
(In reply to comment #6) > My main point is that the font shouldn't change UI elements. I doubt it should > be an icon: seems more like it should be a part of the theme. I think you agree - as I understand comment #5, Carlos is talking about an image file as part of the gnome-shell theme.
(In reply to comment #7) > (In reply to comment #6) > > My main point is that the font shouldn't change UI elements. I doubt it should > > be an icon: seems more like it should be a part of the theme. > > I think you agree - as I understand comment #5, Carlos is talking about an > image file as part of the gnome-shell theme. I meant that, yes.
Created attachment 269544 [details] [review] popupMenu: Use an image for arrows Until now the arrows were the associated arrow character on the font. This cause some problems like diferent arrows for diferent fonts, and size can be altered because of the font size. To solve that, use an image for the arrows.
Created attachment 269565 [details] [review] popupMenu: Use an image for arrows Until now the arrows were the associated arrow character on the font. This cause some problems like diferent arrows for diferent fonts, and size can be altered because of the font size. To solve that, use an image for the arrows.
Created attachment 269566 [details] [review] popupMenu: Use relative rotation for arrows Currently the animation of the arrows doesn't take into account previous rotation. Since in a incomming patch we will use one arrow and rotate it to generate the four directions, we need that the animation use relative rotation.
Created attachment 269567 [details] [review] popupMenu: Use an image for arrows Until now the arrows were the associated arrow character on the font. This cause some problems like diferent arrows for diferent fonts, and size can be altered because of the font size. To solve that, use an image for the arrows.
Created attachment 269590 [details] [review] popupMenu: Use relative rotation for arrows Currently the animation of the arrows doesn't take into account previous rotation. Since in a incomming patch we will use one arrow and rotate it to generate the four directions, we need that the animation use relative rotation.
Created attachment 269591 [details] [review] popupMenu: Use an image for arrows Until now the arrows were the associated arrow character on the font. This cause some problems like diferent arrows for diferent fonts, and size can be altered because of the font size. To solve that, use an image for the arrows.
Created attachment 269593 [details] [review] popupMenu: Use relative rotation for arrows Currently the animation of the arrows doesn't take into account previous rotation. Since in a incomming patch we will use one arrow and rotate it to generate the four directions, we need that the animation use relative rotation.
Created attachment 269594 [details] [review] popupMenu: Use an image for arrows Until now the arrows were the associated arrow character on the font. This cause some problems like diferent arrows for diferent fonts, and size can be altered because of the font size. To solve that, use an image for the arrows.
Created attachment 269604 [details] screenshot of the patches in action Looks really good to me. The fuzziness from the previous triangles is gone too, which is great.
Created attachment 269686 [details] [review] popupMenu: Rename _arrow_rotation to follow JS covention
Created attachment 269687 [details] [review] popupMenu: Use relative rotation for arrows Currently the animation of the arrows doesn't take into account previous rotation. Since in a incoming patch we will use one arrow and rotate it to generate the four directions, we need that the animation use relative rotation.
Created attachment 269688 [details] [review] popupMenu: Use an image for arrows Until now the arrows were the associated arrow character of the font. This cause some problems like different arrows for different fonts, and size can be altered because of the font size. To solve that, use an image for the arrows.
Patches pushed as: 4950bad2a7d92cbf75c95d809e9a2a6bf293550d a7283864e80048a8fe9d74c5500b84ee71cac779 0418b68051e0bfec3e1a97344e105fa8c875ec05 Adding them here for reference