After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720177 - glvideomixer: texture coordinate does not update with commit "GL_TEXTURE_2D instead of GL_TEXTURE_RECTANGLE"
glvideomixer: texture coordinate does not update with commit "GL_TEXTURE_2D i...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-gl
1.2.1
Other All
: Normal normal
: 1.2.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-10 08:08 UTC by comicfans44
Modified: 2013-12-16 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
small patch to fix the problem (478 bytes, patch)
2013-12-10 08:09 UTC, comicfans44 		committed Details | Review

Description comicfans44 2013-12-10 08:08:04 UTC 
in commit fffdcb "gl: Use GL_TEXTURE_2D instead of GL_TEXTURE_RECTANGLE"
glvideomixer still uses texture coordinate in GL_TEXTURE_RECTANGLE, leads wrong result. this simple patch fix it.
Comment 1 comicfans44 2013-12-10 08:09:37 UTC 
Created attachment 263890 [details] [review]
small patch to fix the problem

just replace texture coordinate with [0~1] range values
Comment 2 Sebastian Dröge (slomo) 2013-12-14 18:13:41 UTC 
Please attach patches in "git format-patch" format in the future, and make sure to use your real name there :) I got it from a previous patch you provided in the past now.

commit 63d8f0332846a48adbe37a2c97a377ea0654ce72
Author: Wang Xin-yu (王昕宇) <comicfans44@gmail.com>
Date:   Sat Dec 14 19:12:09 2013 +0100

    glvideomixer: Use correct coordinates after the switch from GL_TEXTURE_RECTANGLE to GL_TEXTURE_2D
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720177
Comment 3 comicfans44 2013-12-16 00:55:10 UTC 
(In reply to comment #2)
> Please attach patches in "git format-patch" format in the future, and make sure
> to use your real name there :) I got it from a previous patch you provided in
> the past now.
> 
> commit 63d8f0332846a48adbe37a2c97a377ea0654ce72
> Author: Wang Xin-yu (王昕宇) <comicfans44@gmail.com>
> Date:   Sat Dec 14 19:12:09 2013 +0100
> 
>     glvideomixer: Use correct coordinates after the switch from
> GL_TEXTURE_RECTANGLE to GL_TEXTURE_2D
> 
>     https://bugzilla.gnome.org/show_bug.cgi?id=720177

Sorry, I'm not familiar with bugzilla currently, I'll try better