After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720145 - app menu: standardize Help/About/Quit
app menu: standardize Help/About/Quit
Status: RESOLVED OBSOLETE
Product: gucharmap
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-09 22:05 UTC by Michael Catanzaro
Modified: 2016-10-16 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
app menu: standardize Help/About/Quit (1.25 KB, patch)
2013-12-09 22:05 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2013-12-09 22:05:22 UTC
* Remove the separator beneath About
* Rename Close Window to Quit

The action app.close is unchanged for the time being, since there's not
(yet) agreement on whether Quit will close every window or just the
current one. But it is going to be named Quit.
Comment 1 Michael Catanzaro 2013-12-09 22:05:23 UTC
Created attachment 263857 [details] [review]
app menu: standardize Help/About/Quit
Comment 2 Christian Persch 2013-12-09 22:16:46 UTC
Why invent another name «Quit» for the well-known self-describing action «Close Window» ?
Comment 3 Michael Catanzaro 2013-12-09 22:59:21 UTC
I don't have a strong preference as long as gucharmap is consistent with other GNOME apps. Having looked at a LOT of app menus today, I think gucharmap is likely the only one to use Close Window.

The draft HIG I forgot to link to in this patch is [1]. There's discussion at [2], including unresolved debate as to whether Quit should close the current window or all windows, but nobody has proposed an alternative name for the menu item.

[1] https://wiki.gnome.org/Design/HIG/ApplicationMenus
[2] https://mail.gnome.org/archives/desktop-devel-list/2013-November/msg00024.html
Comment 4 Michael Catanzaro 2013-12-10 21:42:39 UTC
I brought this up again at https://mail.gnome.org/archives/desktop-devel-list/2013-December/msg00017.html
Comment 5 Michael Catanzaro 2014-01-05 03:08:01 UTC
Hey Christian, are you OK with me renaming the last entry from Close Window to Quit? Every other GNOME application I've checked, including those where the last entry in the app menu only closes the current window, use the name Quit (including gnome-terminal and aisleriot).
Comment 6 Michael Catanzaro 2015-02-03 19:55:32 UTC
Since > 1 year without objection and gucharmap is the only GNOME app left without the standard final section in the app menu, I will push this.

Attachment 263857 [details] pushed as 419bc9f - app menu: standardize Help/About/Quit
Comment 7 Christian Persch 2015-02-03 20:59:13 UTC
Don't commit to gucharmap without approval; 'no response' != approval.