After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720127 - Initial binding for git_diff_find_similar
Initial binding for git_diff_find_similar
Status: RESOLVED FIXED
Product: libgit2-glib
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-09 19:12 UTC by Techlive Zheng
Modified: 2019-02-22 03:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Initial binding for git_diff_find_similar (2.19 KB, patch)
2013-12-09 19:12 UTC, Techlive Zheng
none Details | Review

Description Techlive Zheng 2013-12-09 19:12:57 UTC
I am working on gitg to make it show file renames, this an initial bindng for
`git_diff_find_similar` funciton in libgit2. Currently, NULL is given as the
second parameter of `git_diff_find_similar`, which needs to add further support
for `git_diff_find_options`.
Comment 1 Techlive Zheng 2013-12-09 19:12:59 UTC
Created attachment 263836 [details] [review]
Initial binding for git_diff_find_similar

Currently, use NULL as git_diff_find_options, which needs binding too.
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-12-09 20:55:39 UTC
Hey Tech,
patch looks good, feel free to push it. Although I'd rather see a dummy GitgDiffFindOptions object passed in with allow-none, so we do not break the api in the near future.
Comment 3 Techlive Zheng 2013-12-10 09:57:30 UTC
Okay, will revise this patch a little later.
Comment 4 Techlive Zheng 2013-12-21 17:26:21 UTC
See branch wip/techlivezh/git-diff-find-similar
Comment 5 jessevdk@gmail.com 2013-12-23 09:24:05 UTC
Maybe you forgot to push that branch, can you also upload the new patch here?
Comment 6 jessevdk@gmail.com 2013-12-23 09:25:18 UTC
My bad, wrong repo. But otherwise, yes, please add GgitDiffFindOptions.
Comment 7 Techlive Zheng 2013-12-23 09:25:53 UTC
(In reply to comment #5)
> Maybe you forgot to push that branch, can you also upload the new patch here?

Have not worked on this yet, will do later.
Comment 8 jessevdk@gmail.com 2014-06-27 12:27:12 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.