GNOME Bugzilla – Bug 720127
Initial binding for git_diff_find_similar
Last modified: 2019-02-22 03:51:51 UTC
I am working on gitg to make it show file renames, this an initial bindng for `git_diff_find_similar` funciton in libgit2. Currently, NULL is given as the second parameter of `git_diff_find_similar`, which needs to add further support for `git_diff_find_options`.
Created attachment 263836 [details] [review] Initial binding for git_diff_find_similar Currently, use NULL as git_diff_find_options, which needs binding too.
Hey Tech, patch looks good, feel free to push it. Although I'd rather see a dummy GitgDiffFindOptions object passed in with allow-none, so we do not break the api in the near future.
Okay, will revise this patch a little later.
See branch wip/techlivezh/git-diff-find-similar
Maybe you forgot to push that branch, can you also upload the new patch here?
My bad, wrong repo. But otherwise, yes, please add GgitDiffFindOptions.
(In reply to comment #5) > Maybe you forgot to push that branch, can you also upload the new patch here? Have not worked on this yet, will do later.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.