GNOME Bugzilla – Bug 720113
integrate cookies list into preferences dialog
Last modified: 2013-12-09 19:56:38 UTC
Instead of having a list of cookies in a separate dialog I think it makes sense to get to the list of cookies from where you set the policy for cookies in the Privacy tab of the preferences.
Created attachment 263822 [details] [review] Create a new clear data dialog
Created attachment 263823 [details] [review] Create a new cookies dialog
Created attachment 263824 [details] [review] Hook up new cookies dialog to prefs dialog
Created attachment 263825 [details] [review] Remove personal data manager
Review of attachment 263822 [details] [review]: ::: src/clear-data-dialog.c @@ +207,3 @@ +clear_data_dialog_set_flags (ClearDataDialog *dialog, + ClearDataDialogFlags flags) +{ if flags and priv->flags are the same, maybe we don't need to call update_flags()?
Review of attachment 263823 [details] [review]: ok
Review of attachment 263824 [details] [review]: ok
Review of attachment 263825 [details] [review]: Cool!
lgtm
Attachment 263822 [details] pushed as 0a301e9 - Create a new clear data dialog Attachment 263823 [details] pushed as 0178641 - Create a new cookies dialog Attachment 263824 [details] pushed as fe3929b - Hook up new cookies dialog to prefs dialog Attachment 263825 [details] pushed as d84c226 - Remove personal data manager