After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720113 - integrate cookies list into preferences dialog
integrate cookies list into preferences dialog
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Preferences
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-09 17:33 UTC by William Jon McCann
Modified: 2013-12-09 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Create a new clear data dialog (23.51 KB, patch)
2013-12-09 17:33 UTC, William Jon McCann 		committed Details | Review
Create a new cookies dialog (24.54 KB, patch)
2013-12-09 17:33 UTC, William Jon McCann 		committed Details | Review
Hook up new cookies dialog to prefs dialog (8.92 KB, patch)
2013-12-09 17:33 UTC, William Jon McCann 		committed Details | Review
Remove personal data manager (73.93 KB, patch)
2013-12-09 17:34 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2013-12-09 17:33:24 UTC 
Instead of having a list of cookies in a separate dialog I think it makes sense to get to the list of cookies from where you set the policy for cookies in the Privacy tab of the preferences.
Comment 1 William Jon McCann 2013-12-09 17:33:49 UTC 
Created attachment 263822 [details] [review]
Create a new clear data dialog
Comment 2 William Jon McCann 2013-12-09 17:33:54 UTC 
Created attachment 263823 [details] [review]
Create a new cookies dialog
Comment 3 William Jon McCann 2013-12-09 17:33:59 UTC 
Created attachment 263824 [details] [review]
Hook up new cookies dialog to prefs dialog
Comment 4 William Jon McCann 2013-12-09 17:34:04 UTC 
Created attachment 263825 [details] [review]
Remove personal data manager
Comment 5 Claudio Saavedra 2013-12-09 19:39:35 UTC 
Review of attachment 263822 [details] [review]:

::: src/clear-data-dialog.c
@@ +207,3 @@
+clear_data_dialog_set_flags (ClearDataDialog     *dialog,
+			     ClearDataDialogFlags flags)
+{

if flags and priv->flags are the same, maybe we don't need to call update_flags()?
Comment 6 Claudio Saavedra 2013-12-09 19:40:20 UTC 
Review of attachment 263823 [details] [review]:

ok
Comment 7 Claudio Saavedra 2013-12-09 19:40:51 UTC 
Review of attachment 263824 [details] [review]:

ok
Comment 8 Claudio Saavedra 2013-12-09 19:41:05 UTC 
Review of attachment 263825 [details] [review]:

Cool!
Comment 9 Claudio Saavedra 2013-12-09 19:41:27 UTC 
lgtm
Comment 10 William Jon McCann 2013-12-09 19:56:23 UTC 
Attachment 263822 [details] pushed as 0a301e9 - Create a new clear data dialog
Attachment 263823 [details] pushed as 0178641 - Create a new cookies dialog
Attachment 263824 [details] pushed as fe3929b - Hook up new cookies dialog to prefs dialog
Attachment 263825 [details] pushed as d84c226 - Remove personal data manager