After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720106 - Simplify the _NET_WM_WINDOW_OPACITY handling
Simplify the _NET_WM_WINDOW_OPACITY handling
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-09 15:05 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-12-09 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
compositor: Remove atom_x_root_pixmap (1.52 KB, patch)
2013-12-09 15:05 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
Move _NET_WM_WINDOW_OPACITY handling to the standard window-props interface (13.91 KB, patch)
2013-12-09 15:05 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-12-09 15:05:01 UTC 
Some cleanups I'm doing for the Wayland branch. This removes one of the
easier X11 dependencies from MetaWindowActor.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-12-09 15:05:02 UTC 
Created attachment 263815 [details] [review]
compositor: Remove atom_x_root_pixmap

It's unused
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-12-09 15:05:08 UTC 
Created attachment 263816 [details] [review]
Move _NET_WM_WINDOW_OPACITY handling to the standard window-props interface

This removes one X11 dependency that the MetaWindowActor interface has,
making it easier for us to use Wayland on this one...
Comment 3 Owen Taylor 2013-12-09 20:01:04 UTC 
Review of attachment 263815 [details] [review]:

::: src/compositor/compositor.c
@@ +1537,1 @@
   compositor->atom_net_wm_window_opacity = atoms[1];

You should renumber this to atoms[0] - I know you are removing this altogether in the next patch, but this will break bisectability with a crash.
Comment 4 Owen Taylor 2013-12-09 20:08:19 UTC 
Review of attachment 263816 [details] [review]:

Looks fine with one small thing.

::: src/compositor/meta-window-actor.c
@@ +351,3 @@
 
+static gboolean
+is_transparent (MetaWindowActor *self)

is_not_opaque() or maybe is_argb() please. transparent properly means "completely transparent", and isn't an obvious fit for say, a GTK+ CSD window with rounded corners.

@@ +795,2 @@
   /*
+   * Do not add shadows to transparent windows; eventually we should generate

So don't use "transparent" here either.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-12-09 20:51:26 UTC 
Attachment 263815 [details] pushed as 93a8933 - compositor: Remove atom_x_root_pixmap
Attachment 263816 [details] pushed as 1db95bc - Move _NET_WM_WINDOW_OPACITY handling to the standard window-props interface


Pushed with both fixes.