After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720103 - videodecoder: Introduce sink_query/src_query
videodecoder: Introduce sink_query/src_query
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-09 13:59 UTC by Nicolas Dufresne (ndufresne)
Modified: 2013-12-09 15:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add src_query() sink_query() virtual method (6.31 KB, patch)
2013-12-09 13:59 UTC, Nicolas Dufresne (ndufresne)
committed Details | Review

Description Nicolas Dufresne (ndufresne) 2013-12-09 13:59:59 UTC
Created attachment 263813 [details] [review]
Add src_query() sink_query() virtual method

I am implementing a V4L2 based decoder which has dynamic capabilities. This mean, i need to implement caps query. I had the option to add a src_get_caps()/sink_get_caps() but thought this is a rare case, and it's simply more generic to have access to all queries, like we do for event.
Comment 1 Nicolas Dufresne (ndufresne) 2013-12-09 14:42:28 UTC
Comment on attachment 263813 [details] [review]
Add src_query() sink_query() virtual method

commit 09a6ca97d246c798be267478b3a85d90d1ccde9b
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Wed Nov 27 16:39:52 2013 -0500

    videodecoder: Add sink_query() src_query() virtual
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720103
Comment 2 Sebastian Dröge (slomo) 2013-12-09 15:35:55 UTC
Also added in the encoder for consistency. We should try to keep their APIs as similar as possible.

commit 729e3c8a1034ad7cb53e69d6578de66fdc342d6e
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Dec 9 16:33:40 2013 +0100

    videoencoder: Add sink_query() src_query() virtual functions
    
    Based on the videodecoder change by Nicolas Dufresne and applied
    here for consistency.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720103