After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720098 - Make prefs a GtkDialog subclass
Make prefs a GtkDialog subclass
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Preferences
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-09 10:44 UTC by William Jon McCann
Modified: 2013-12-09 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
prefs: use GtkDialog instead of EphyDialog (63.83 KB, patch)
2013-12-09 10:45 UTC, William Jon McCann 		committed Details | Review
prefs: make the dialog modal (1.06 KB, patch)
2013-12-09 10:45 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2013-12-09 10:44:48 UTC 
In order to simplify things I think it makes sense to make the preferences dialog a GtkDialog subclass instead of EphyDialog.
Comment 1 William Jon McCann 2013-12-09 10:45:11 UTC 
Created attachment 263806 [details] [review]
prefs: use GtkDialog instead of EphyDialog
Comment 2 William Jon McCann 2013-12-09 10:45:15 UTC 
Created attachment 263807 [details] [review]
prefs: make the dialog modal
Comment 3 Claudio Saavedra 2013-12-09 12:43:28 UTC 
Review of attachment 263806 [details] [review]:

I think it looks good. I think.
Comment 4 Claudio Saavedra 2013-12-09 12:43:50 UTC 
Review of attachment 263807 [details] [review]:

I think the same.
Comment 5 William Jon McCann 2013-12-09 12:46:46 UTC 
Attachment 263806 [details] pushed as e65f35d - prefs: use GtkDialog instead of EphyDialog
Attachment 263807 [details] pushed as d31d3ab - prefs: make the dialog modal