After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720088 - gsf-libxml: mark some functions G_GNUC_PRINTF
gsf-libxml: mark some functions G_GNUC_PRINTF
Product: libgsf
Classification: Core
Component: General
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Reported: 2013-12-09 00:53 UTC by Allison Karlitskaya (desrt)
Modified: 2013-12-14 02:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

gsf-libxml: mark some functions G_GNUC_PRINTF (1.54 KB, patch)
2013-12-09 00:53 UTC, Allison Karlitskaya (desrt)
none Details | Review

Description Allison Karlitskaya (desrt) 2013-12-09 00:53:02 UTC
Picked up by clang...
Comment 1 Allison Karlitskaya (desrt) 2013-12-09 00:53:04 UTC
Created attachment 263780 [details] [review]
gsf-libxml: mark some functions G_GNUC_PRINTF

Mark these functions as accepting printf-style format strings, so that
when they pass their arguments on to g_logv() the compiler knows not to
Comment 2 Morten Welinder 2013-12-14 01:58:59 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

For reference: that patch didn't work for me.  The attribute can only be put
on a declaration, not on function definition.
Comment 3 Allison Karlitskaya (desrt) 2013-12-14 02:28:10 UTC
Indeed, this is the second time I've heard that.  Thanks for the fix!