After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720083 - sysdeps: grok -isystem
sysdeps: grok -isystem
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-12-08 21:27 UTC by Allison Karlitskaya (desrt)
Modified: 2013-12-16 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sysdeps: grok -isystem (1.19 KB, patch)
2013-12-08 21:27 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-12-08 21:27:24 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2013-12-08 21:27:26 UTC 
Created attachment 263778 [details] [review]
sysdeps: grok -isystem

sysdeps inspects the user's CFLAGS and CPPFLAGS to try to get a list of
system directories in which to search for c_include-type sysdeps.

It does this by looking for -I flags.  Make sure it also includes
-isystem.
Comment 2 Colin Walters 2013-12-16 21:32:09 UTC 
Review of attachment 263778 [details] [review]:

One comment, feel free to commit with or without change.

::: jhbuild/utils/systeminstall.py
@@ +73,3 @@
                 while True:
                     arg = itr.next()
+                    if arg.strip() == '-I' or arg.strip() == '-isystem':

arg.strip() in ['-I', '-isystem'] is a little cleaner.
Comment 3 Allison Karlitskaya (desrt) 2013-12-16 21:35:41 UTC 
Attachment 263778 [details] pushed as c637d7c - sysdeps: grok -isystem