After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720072 - portability: only link to -ldl if needed
portability: only link to -ldl if needed
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-08 18:02 UTC by Allison Karlitskaya (desrt)
Modified: 2013-12-08 18:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
portability: only link to -ldl if needed (1.40 KB, patch)
2013-12-08 18:02 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-12-08 18:02:28 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2013-12-08 18:02:36 UTC 
Created attachment 263766 [details] [review]
portability: only link to -ldl if needed

We use -ldl in some of our testcases to mock out some system calls via
interposing, using dlsym() to chain up.

Make sure we only use this if we really need to.  Many systems have
dlsym() in the C library and no -ldl.
Comment 2 Koop Mast (kwm) 2013-12-08 18:18:44 UTC 
Review of attachment 263766 [details] [review]:

Look good, and build/run tested on FreeBSD 10.
Comment 3 Allison Karlitskaya (desrt) 2013-12-08 18:23:00 UTC 
Attachment 263766 [details] pushed as c8603e6 - portability: only link to -ldl if needed

Works on Linux too.  Thanks for the review.