After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720017 - sessionMode fixes
sessionMode fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-06 21:08 UTC by Florian Müllner
Modified: 2013-12-07 09:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sessionMode: Fix left-over variable in _loadMode() (1.06 KB, patch)
2013-12-06 21:08 UTC, Florian Müllner 		committed Details | Review
sessionMode: Rename _getModes() (1.16 KB, patch)
2013-12-06 21:09 UTC, Florian Müllner 		committed Details | Review
sessionMode: Fix listModes() (935 bytes, patch)
2013-12-06 21:09 UTC, Florian Müllner 		committed Details | Review
sessionMode: Add back external session modes (928 bytes, patch)
2013-12-06 21:09 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-12-06 21:08:55 UTC 
Both listing modes and using non-builtin modes (classic!) are completely borked at the moment - see patches.
Comment 1 Florian Müllner 2013-12-06 21:08:58 UTC 
Created attachment 263697 [details] [review]
sessionMode: Fix left-over variable in _loadMode()

Commit da4238ec681c7ca dropped a variable, but didn't replace all
consumers.
Comment 2 Florian Müllner 2013-12-06 21:09:03 UTC 
Created attachment 263698 [details] [review]
sessionMode: Rename _getModes()

Since commit da4238ec681c7ca, the function doesn't return anything,
so rename it to _loadModes() to reflect this.
Comment 3 Florian Müllner 2013-12-06 21:09:07 UTC 
Created attachment 263699 [details] [review]
sessionMode: Fix listModes()

Commit da4238ec681c7ca just broke that function completely by
calling array methods on objects and other funny stuff. Fix it.
Comment 4 Florian Müllner 2013-12-06 21:09:12 UTC 
Created attachment 263700 [details] [review]
sessionMode: Add back external session modes

Since commit da4238ec681c7ca, external session modes are no longer
loaded during start-up; bring them back.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-12-06 21:50:41 UTC 
Review of attachment 263697 [details] [review]:

OK.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-12-06 21:51:15 UTC 
Review of attachment 263698 [details] [review]:

You could also make it return 'modes' instead, I suppose, but this is OK.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-12-06 22:20:19 UTC 
Review of attachment 263699 [details] [review]:

Yep.
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-12-06 22:20:42 UTC 
Review of attachment 263700 [details] [review]:

Sure.
Comment 9 Florian Müllner 2013-12-07 09:11:12 UTC 
Attachment 263697 [details] pushed as 46bac30 - sessionMode: Fix left-over variable in _loadMode()
Attachment 263698 [details] pushed as c9f2a0f - sessionMode: Rename _getModes()
Attachment 263699 [details] pushed as 4d9a16f - sessionMode: Fix listModes()
Attachment 263700 [details] pushed as 8e668ca - sessionMode: Add back external session modes