GNOME Bugzilla – Bug 719974
Handle failures fetching the GnomeRRScreen
Last modified: 2013-12-10 15:25:26 UTC
If gnome-shell is not available (or randomly deadlocks as it's my case, investigating that :) when gnome-settings-daemon is (re)starting, the async call to get a GnomeRRScreen on the power plugin will fail, causing crashes soon after when priv->rr_screen is assumed to exist. I'm attaching a patch to fix that
Created attachment 263670 [details] [review] power: bail out early if the GnomeRRScreen could not be created This may happen in the case gnome-shell is not running when g-s-d starts up. This fixes a crash in such situation, as priv->rr_screen was assumed to exist soon after.
Review of attachment 263670 [details] [review]: looks good to me
Review of attachment 263670 [details] [review]: That shouldn't happen when gnome-shell isn't running (unless it simply won't start) as we watch for the gnome-shell interface in gnome-desktop. What's the case you're trying to fix?
This crash is admittedly unlikely, I hit it from time to time when doing gnome-settings-daemon -r in other shell for devel purposes, the g-s-d restart makes gnome-shell trip into some deadlock, so it fails to reply to that request on the new g-s-d instance, making it crash too. The most glaring bug here is obviously gnome-shell's, but I still haven't caught it in a situation where I could debug it, making g-s-d a bit more robust can't hurt though.
Review of attachment 263670 [details] [review]: Fine then.
Attachment 263670 [details] pushed as 229ed65 - power: bail out early if the GnomeRRScreen could not be created