After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719972 - Fix critical warnings on shutdown
Fix critical warnings on shutdown
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Carlos Garnacho
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-06 13:58 UTC by Carlos Garnacho
Modified: 2013-12-10 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wacom: Fix critical warnings on shutdown (1.73 KB, patch)
2013-12-06 13:59 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2013-12-06 13:58:31 UTC 
On ordered shutdown, the wacom plugin attempts to unset the passive grabs on pad buttons, but the code seems to confuse GdkDevices with GsdWacomDevices, causing critical warnings mainly (the passive grabs wouldn't stay long anyway if the client disappears). I'm attaching a patch to fix this
Comment 1 Carlos Garnacho 2013-12-06 13:59:04 UTC 
Created attachment 263668 [details] [review]
wacom: Fix critical warnings on shutdown

GdkDevices aint' GsdWacomDevices, so lookup the latter from the former.
Comment 2 Bastien Nocera 2013-12-10 11:00:33 UTC 
Review of attachment 263668 [details] [review]:

Looks good.
Comment 3 Carlos Garnacho 2013-12-10 15:06:47 UTC 
Attachment 263668 [details] pushed as 935a0b1 - wacom: Fix critical warnings on shutdown